search

gesinn-it-pub / mediawiki-extensions-PageForms

Fork of MediaWiki extension PageForms that aims to simplify contribution through hosting on GitHub instead of Gerrit, improved quality through better test coverage (to be done) and continuous integration.
Other
2 stars 4 forks source link

Parser function breaks in 5.3.4.6 #36

Closed krabina closed 1 year ago

krabina commented 1 year ago

This field definition showing a set of subpages works in 5.3.4.4 (301aad4), but breaks in 5.3.4.6 (80f19f8) {{{field|Seite|input type=combobox|values={{#arraymap:{{SUBPAGES}}|,|@@@@|{{#explode:@@@@|{{FULLPAGENAME}}/|1}}|;}}|delimiter=;}}}

image

gesinn-it-gea commented 1 year ago

Looking at the screenshots: both are in multi-instance templates, right? Are both screenshots taken with 5.3.4.6?

krabina commented 1 year ago

yes. and both show the problem (double dropdown-arrow), if you try to click, the above picture is happening.

krabina commented 1 year ago

In an empty field it is working fine. The problem only shows when you re-edit a page where there is already a value in the field

gesinn-it-gea commented 1 year ago

It's an CSS issue. Unfortunately, we do not have visual regression testing yet...

krabina commented 1 year ago

Fixed in current master, thank you!

krabina commented 1 year ago

Not quite: works for new fields in multiple instance template, but not for ones holding existing values.

krabina commented 1 year ago

Upgrading again to 5.3.4.6 worked now, strangely. Maybe some caching issue. Thus closing...