Open ahtrotta opened 1 year ago
Here's another example from this test. The map has locateAppMapDir
, but then it doesn't capture the function call to appmapDirFromConfig
from within locateApMapDir
.
@ahtrotta The agent works by instrumenting function declarations not function applications. As you can imagine, changing that is big leap. Are the the functions pruneWithFilter and displayMessage declared in whitelisted file?
Why isn't the function call to appmapDirFromConfig from within locateApMapDir recorded?
On Wed, Apr 26, 2023 at 4:42 PM Laurent Christophe @.***> wrote:
@ahtrotta https://github.com/ahtrotta The agent works by instrumenting function declarations not function applications. As you can imagine, changing that is big leap. Are the the functions pruneWithFilter and displayMessage declared in whitelisted file?
— Reply to this email directly, view it on GitHub https://github.com/getappmap/appmap-agent-js/issues/210#issuecomment-1524019205, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAVC63HS6OOVMSYLZ4NLUTXDGCBRANCNFSM6AAAAAAWRYDQ2A . You are receiving this because you are subscribed to this thread.Message ID: @.***>
If it was not excluded, it is a bug.
Why? Can someone please explain in more than one line.
On Fri, Apr 28, 2023 at 3:18 PM Laurent Christophe @.***> wrote:
If it was not excluded, it is a bug.
— Reply to this email directly, view it on GitHub https://github.com/getappmap/appmap-agent-js/issues/210#issuecomment-1527989909, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAVC64SWQE6JPRJRXQT4JLXDQJZDANCNFSM6AAAAAAWRYDQ2A . You are receiving this because you commented.Message ID: @.***>
I mapped
cli
inappmap-js
and got some maps, but I noticed that many of them are missing functions. For example, the map from this test case is missingpruneWithFilter
anddisplayMessage
.For context, here is my
appmap.yml
file (this file is inpackages/cli
) that was generated by the JS agent: