search

getditto / DittoAndroidTools

Diagnostic and Debugging Tools for Ditto Android SDK
MIT License
6 stars 1 forks source link

fix gradle and build errors #77

Closed rajramsaroop closed 5 months ago

rajramsaroop commented 6 months ago

There were some build errors with the tools app related to gradle dependencies + error in code.

Should now be able to build and run the app.

rajramsaroop commented 6 months ago

Question - does HealthMetrics have to be a separate module? Seems like it could just be a package in DittoHeartbeat module. They're related and metrics wouldn't be used anywhere else?

bplattenburg commented 6 months ago

Question - does HealthMetrics have to be a separate module? Seems like it could just be a package in DittoHeartbeat module. They're related and metrics wouldn't be used anywhere else?

on the Swift side its separate because the HealthMetricProvider protocol needs to be visible to other tools so that they can conform and provide health metrics. I think the same thing makes sense here?

texasRanger09 commented 6 months ago

Question - does HealthMetrics have to be a separate module? Seems like it could just be a package in DittoHeartbeat module. They're related and metrics wouldn't be used anywhere else?

on the Swift side its separate because the HealthMetricProvider protocol needs to be visible to other tools so that they can conform and provide health metrics. I think the same thing makes sense here?

Yeah, the idea is that HealthMetrics will be added to other tools. It will be used to add the given tools data to the Heartbeat tool. It is a seperate module, but we don't need to publish it to Maven as a seperate module. We just need to make sure it is included in the .aar for each module that uses it.

bplattenburg commented 6 months ago

@zmarkan did https://github.com/getditto/DittoAndroidTools/pull/79 include these changes as well?

zmarkan commented 6 months ago

@bplattenburg yes, it included everything apart from the last commit with namespace change - https://github.com/getditto/DittoAndroidTools/pull/77/commits/abf9ea971197a3742557dd70ade3e8c4774d8979

bplattenburg commented 6 months ago

I think we're good to close this then? @rajramsaroop

rajramsaroop commented 6 months ago

I think we're good to close this then? @rajramsaroop

Gonna include the changes Ben mentioned, but otherwise Zan's PR covered everything else.

rajramsaroop commented 5 months ago

I updated the namespace to match what I will update in my other PR to fix the duplicate class issue.

This PR also updates the build.gradle to use version catalog for the plugin imports.