Closed MdAsifHossainNadim closed 3 weeks ago
[!CAUTION]
Review failed
The pull request is closed.
The changes in this pull request focus on the Dokan_WPML
class within the dokan-wpml.php
file. A new query variable, printful
, has been added to the get_settings_query_vars_map
method, which now includes a filter to enhance extensibility for settings related to Printful integration. Additionally, the register_vendor_verification_method
method has been updated with type hinting for its $method_id
parameter, improving clarity and enforcing type safety in the method's signature.
File | Change Summary |
---|---|
dokan-wpml.php | - Added printful query variable to get_settings_query_vars_map method with a filter. |
- Updated register_vendor_verification_method to include type hinting for $method_id . |
register_vendor_verification_method
method in the Dokan_WPML
class, enhancing its functionality and type safety, which aligns with the updates made in the main PR.Need Testing
, Dev Review Done
🐇 In the code, I hop and play,
New settings bloom, come what may.
With filters added, oh so bright,
Type hints guide us, pure delight!
Let's integrate with Printful's cheer,
In Dokan's world, we spread good cheer! 🌼
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Summary by CodeRabbit
New Features
Improvements