Closed shashwatahalder01 closed 2 months ago
The pull request introduces several enhancements across multiple page classes in the testing framework. Key changes include the addition of new methods for handling dropdown selections and navigation, modifications to existing methods for improved loading and visibility checks, and updates to CSS selectors for consistency. Additionally, the test suites have been adjusted to activate previously skipped tests and refine data structures used in settings. Overall, these changes aim to streamline navigation and interaction logic within the application.
Files | Change Summary |
---|---|
tests/pw/pages/basePage.ts |
Added method selectByValueAndWaitForResponseAndLoadState to select dropdown options and wait for network responses. |
tests/pw/pages/customerPage.ts |
Added method gotoSingleStore for navigating to a specific store's details page. |
tests/pw/pages/privacyPolicyPage.ts |
Updated to extend CustomerPage , modified navigation methods for improved loading and visibility checks. |
tests/pw/pages/selectors.ts |
Updated CSS selectors for storeContactForm to a more modern syntax. |
tests/pw/pages/settingsPage.ts |
Changed method parameter type in setDokanMenuManagerSettings from dokanSettings['menuManager'] to string[] . |
tests/pw/pages/singleStorePage.ts |
Replaced goIfNotThere with gotoSingleStore in multiple methods, updated sorting method to use the new selection method, and added assertions for product cards. |
tests/pw/pages/storeListingPage.ts |
Replaced goIfNotThere with gotoUntilNetworkidle , updated sorting logic, and simplified filtering method. |
tests/pw/pages/withdrawsPage.ts |
Added visibility assertion for withdraw cell in WithdrawsPage . |
tests/pw/tests/e2e/privacyPolicy.spec.ts |
Activated previously skipped test suite and simplified test setup. |
tests/pw/tests/e2e/productAdvertising.spec.ts |
Marked three test cases as potentially slower with test.slow() annotation. |
tests/pw/tests/e2e/settings.spec.ts |
Updated argument for setDokanMenuManagerSettings to focus on menus property. |
tests/pw/tests/e2e/singleStore.spec.ts |
Activated previously skipped test case for viewing store terms and conditions. |
tests/pw/utils/dbData.ts |
Modified privacyPolicySettings and sideBarsWidgets properties for clarity and introduced emptySideBarsWidgets . |
tests/pw/utils/testData.ts |
Added a new menus array in menuManager with various menu options. |
SingleStorePage
class by changing method selectByValueAndWaitForResponse
to selectByValueAndWaitForResponseAndLoadState
, which is directly related to the new method added in this PR.🐇 In the land of code where the rabbits play,
New methods hop in to brighten the day.
With selectors so sleek and tests that now run,
Navigation's a breeze, oh what coding fun!
So let’s celebrate with a joyful cheer,
For every new feature brings us all near! 🎉
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
All Submissions:
Changes proposed in this Pull Request:
Related Pull Request(s)
Closes
How to test the changes in this Pull Request:
Changelog entry
Title
Detailed Description of the pull request. What was previous behaviour and what will be changed in this PR.
Before Changes
Describe the issue before changes with screenshots(s).
After Changes
Describe the issue after changes with screenshot(s).
Feature Video (optional)
Link of detailed video if this PR is for a feature.
PR Self Review Checklist:
FOR PR REVIEWER ONLY:
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Refactor
PrivacyPolicyPage
andStoreListingPage
classes.