getdokan / dokan

Multivendor marketplace platform
https://wordpress.org/plugins/dokan-lite/
260 stars 204 forks source link

add privacy policy tests (automation suite) #2378

Closed shashwatahalder01 closed 2 months ago

shashwatahalder01 commented 2 months ago

All Submissions:

Changes proposed in this Pull Request:

Related Pull Request(s)

Closes

How to test the changes in this Pull Request:

Changelog entry

Title

Detailed Description of the pull request. What was previous behaviour and what will be changed in this PR.

Before Changes

Describe the issue before changes with screenshots(s).

After Changes

Describe the issue after changes with screenshot(s).

Feature Video (optional)

Link of detailed video if this PR is for a feature.

PR Self Review Checklist:

FOR PR REVIEWER ONLY:

As a reviewer, your feedback should be focused on the idea, not the person. Seek to understand, be respectful, and focus on constructive dialog.

As a contributor, your responsibility is to learn from suggestions and iterate your pull request should it be needed based on feedback. Seek to collaborate and produce the best possible contribution to the greater whole.

Summary by CodeRabbit

coderabbitai[bot] commented 2 months ago

Walkthrough

The pull request introduces several enhancements across multiple page classes in the testing framework. Key changes include the addition of new methods for handling dropdown selections and navigation, modifications to existing methods for improved loading and visibility checks, and updates to CSS selectors for consistency. Additionally, the test suites have been adjusted to activate previously skipped tests and refine data structures used in settings. Overall, these changes aim to streamline navigation and interaction logic within the application.

Changes

Files Change Summary
tests/pw/pages/basePage.ts Added method selectByValueAndWaitForResponseAndLoadState to select dropdown options and wait for network responses.
tests/pw/pages/customerPage.ts Added method gotoSingleStore for navigating to a specific store's details page.
tests/pw/pages/privacyPolicyPage.ts Updated to extend CustomerPage, modified navigation methods for improved loading and visibility checks.
tests/pw/pages/selectors.ts Updated CSS selectors for storeContactForm to a more modern syntax.
tests/pw/pages/settingsPage.ts Changed method parameter type in setDokanMenuManagerSettings from dokanSettings['menuManager'] to string[].
tests/pw/pages/singleStorePage.ts Replaced goIfNotThere with gotoSingleStore in multiple methods, updated sorting method to use the new selection method, and added assertions for product cards.
tests/pw/pages/storeListingPage.ts Replaced goIfNotThere with gotoUntilNetworkidle, updated sorting logic, and simplified filtering method.
tests/pw/pages/withdrawsPage.ts Added visibility assertion for withdraw cell in WithdrawsPage.
tests/pw/tests/e2e/privacyPolicy.spec.ts Activated previously skipped test suite and simplified test setup.
tests/pw/tests/e2e/productAdvertising.spec.ts Marked three test cases as potentially slower with test.slow() annotation.
tests/pw/tests/e2e/settings.spec.ts Updated argument for setDokanMenuManagerSettings to focus on menus property.
tests/pw/tests/e2e/singleStore.spec.ts Activated previously skipped test case for viewing store terms and conditions.
tests/pw/utils/dbData.ts Modified privacyPolicySettings and sideBarsWidgets properties for clarity and introduced emptySideBarsWidgets.
tests/pw/utils/testData.ts Added a new menus array in menuManager with various menu options.

Possibly related PRs

🐇 In the land of code where the rabbits play,
New methods hop in to brighten the day.
With selectors so sleek and tests that now run,
Navigation's a breeze, oh what coding fun!
So let’s celebrate with a joyful cheer,
For every new feature brings us all near! 🎉


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: -- `I pushed a fix in commit , please review it.` -- `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: -- `@coderabbitai generate unit testing code for this file.` -- `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: -- `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` -- `@coderabbitai read src/utils.ts and generate unit testing code.` -- `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` -- `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.