404, translations and optional multilang

gethugothemes / bigspring-light-hugo

Bigspring is a Hugo startup theme. It has a clean, minimal, fresh UI.

https://gethugothemes.com/products/bigspring/?utm_source=bigspring_github&utm_medium=referral&utm_campaign=github_theme_about

MIT License

198 stars 299 forks source link

404, translations and optional multilang #22

Closed spech66 closed 3 years ago

spech66 commented 3 years ago

Hello. this PR includes the following:

Themed 404 page
Translation of basic strings (read more, ...) according to the languageName setting
Optional multilang support. Remove comment from example page settings allows the page to work in multiple languages. (German example included).

Best regards Sebastian

somratpro commented 3 years ago

Hello @spech66

Thanks for your activity, we really appreciate that. but we use translation by content directory for multilingual, this really helps when the user chooses to use forestry.

spech66 commented 3 years ago

Hi @somratpro thank you for the feedback. I will have a look in this. Does this work with the data and i18n files as well?

somratpro commented 3 years ago

Yes, of course

spech66 commented 3 years ago

I migrated the content folder and tried to get the other approach running as well. However according to the docs and bep the PR would still be required to get data and i18n working or am I missing something? :-)