search

getkirby / ideas

This is the backlog of ideas and feature requests from the last two years. Use our new feedback platform to post your new ideas or vote on existing ideas.
https://feedback.getkirby.com
20 stars 0 forks source link

Panel: fuzzy search #140

Open johannahoerrmann opened 5 years ago

johannahoerrmann commented 5 years ago

Moved from https://github.com/k-next/kirby/issues/1236:

It would be great if the panel search also found phrases with accents when searching for the same phrase without accents.

Screenshots

grafik grafik
distantnative commented 5 years ago

Maybe it could also be an option to open the Panel search up for an extension, so that a plugin could implement Angolia or so for the Panel. Could solve the issue as well this way.

bnomei commented 5 years ago

@distantnative to make the search extendable the search::collection or parts of it need to be a component right? https://github.com/getkirby/kirby/blob/80b69380e672565a849037232c9951d1e32774c8/src/Cms/Search.php#L67

bnomei commented 4 years ago

any progress on this one? it does not seem to hard to implement on php side, right?

nilshoerrmann commented 4 years ago

The issue still exists and we'd be very happy to have a core solution (either directly implemented or provided by plugins).

yoanmalie commented 4 years ago

Would love to see this also for the search content in the template.

distantnative commented 4 years ago

I'm afraid adding it as part of the core would be quite the load. So a plugin would make much more sense to me.

On the PHP side I am looking at https://github.com/loilo/Fuse as a potential library. Since the Panel is calling the API for search anyways, we would "only" need to switch out the ->search() methods.

Those are essentially built on https://github.com/getkirby/kirby/blob/master/src/Cms/Search.php#L38-L128

Maybe we could wrap this as a component which then would be replacable via plugin. And that plugin could provide an implementation of a PHP fuzzy search library - adding fuzzy search to the PHP API as well as Panel search.

bnomei commented 4 years ago

@distantnative make the search a component then. i will happily create a few plugins. client of would love to have algolia results in search. :D

distantnative commented 4 years ago

@bnomei as you can see there is a referenced issue above ;)

nilshoerrmann commented 4 years ago

Handled by https://github.com/getkirby/kirby/pull/2794.