getkirby / kirby

Kirby's core application folder
https://getkirby.com
Other
1.27k stars 167 forks source link

Link overlay of writer field not being translated #3316

Closed silllli closed 3 years ago

silllli commented 3 years ago

Describe the bug

When adding or editing a link in a writer field, the labels in its overlay are not being translated.

To Reproduce
Steps to reproduce the behavior:

  1. Set up a writer field.
  2. Add a link.
  3. Look at the overlay.

Expected behavior

The overlay being translated to the current panel language.

Screenshots

Bildschirmfoto 2021-05-10 um 18 37 49

Kirby Version

3.5.5-rc.1

Console output

No errors in the console.

Desktop (please complete the following information):

afbora commented 3 years ago

Related file that hard coded translation:

https://github.com/getkirby/kirby/blob/3.5.5-rc.1/panel/src/components/Writer/Dialogs/LinkDialog.vue#L25-L43

afbora commented 3 years ago

afbora commented 3 years ago

Its solution will move to 3.5.6 (cherry-picking)

lukasbestle commented 3 years ago