search

getkirby / kirby

Kirby's core application folder
https://getkirby.com
Other
1.27k stars 167 forks source link

Password reset: email should include site name not "Kirby Panel" #3343

Closed distantnative closed 3 years ago

distantnative commented 3 years ago

Currently the email reads

You recently requested a password reset code for the Kirby Panel.

I think most users won't know what Kirby is. So making it sitename Panel or something like this would be better.

lukasbestle commented 3 years ago

Yep, sounds good. I think we should move the site title logic from here to a method in Site or System:

https://github.com/getkirby/kirby/blob/b6cad90/config/api/models/System.php#L55-L61

Then we can use the same logic for the email text for password reset and login codes (both are affected the same way).

distantnative commented 3 years ago

@lukasbestle sounds good, probably System::site() could work well? Do you want to get onto it since you're also more familiar with all the email templates for those auth methods?

lukasbestle commented 3 years ago

What about System::siteName()? I think System::site() is too unspecific.

distantnative commented 3 years ago

Then it should be siteTitle or even just title

bastianallgeier commented 3 years ago

I like System::title()

bastianallgeier commented 3 years ago

✅