search

getkirby / kirby

Kirby's core application folder
https://getkirby.com
Other
1.27k stars 167 forks source link

Nested (Builder) Blocks not working in Migration from old Kirby Builder plugin to new Blocks #4061

Closed MichaelPrecel closed 2 years ago

MichaelPrecel commented 2 years ago

Hi there. Longtime Kirby user!

Description

I have an older project that I'm trying to migrate across to the new Kirby 3.6 (mainly to make use of the new webp/avif image processing abilities).

In this project I have created a pretty complicated page-builder using the old TimOetting/Builder plugin. This includes nested builders. Eg a 'slider' block will have nested 'slide' sub-blocks (image slide/video slide/etc). When I adjust the fields from 'builder' to 'blocks' and update the data, these nested blocks are not being rendered.

Looking at the template.txt file reveals that the top-level blocks are being correctly converted to JSON, but the nested blocks are not. They are converted to JSON, although all special characters are escaped.

Screen Shot 2021-12-20 at 4 10 48 pm

I think as a result of this, the top-level blocks are silently failing when I try to render them on the page.

Any help would be much appreciated!

afbora commented 2 years ago

@bastianallgeier I think this issue should be closed since we've removed the migrations from 3.7 release.