search

getkirby / kirby

Kirby's core application folder
https://getkirby.com
Other
1.27k stars 167 forks source link

`link: false` doesn't working on picker fields #4062

Closed afbora closed 2 years ago

afbora commented 2 years ago

Description

link: false doesn't working on picker fields. I've tested on 3.5.7.1 and this feature is working as well.

cover:
  type: files
  link: false

https://getkirby.com/docs/reference/panel/fields/files#field-properties

Expected behavior

When link disabled, items shouldn't be clickable.

To reproduce

  1. Go to panel
  2. Edit any page that have picker fields
  3. Disable clickable with link: false
  4. Select any item from picker field
  5. Still clickable

Your setup

Kirby Version

3.6.1.1 & Develop branch

Console output

None

Your system

Additional context

distantnative commented 2 years ago

@afbora Could you give https://github.com/getkirby/kirby/tree/fix/4062-picker-field-disable-links a try if it solves it for you (and doesn't break links when enabled)?

afbora commented 2 years ago

Works great for all picker fields 👍

afbora commented 2 years ago

✅