getkirby / kirby

Kirby's core application folder
https://getkirby.com
Other
1.27k stars 167 forks source link

v4.4.0 "Panel is offline" is displayed sporadically #6679

Closed gbdesign2023 closed 6 days ago

gbdesign2023 commented 1 week ago

Since updating to Kirby 4.4.0, I occasionally see the message that the "panel is offline"** for about 1 second. Sometimes the message is displayed up to 3 times in a row. Sometimes not at all for hours. I never saw this message with Kirby 4.3.0 I work locally under macOS 14.6 with MAMP Pro. The browser is Chrome.

https://github.com/user-attachments/assets/3acb4781-bb24-4d64-b741-161983664448

afbora commented 1 week ago

@gbdesign2023 I can't see the video. Could you re-upload, please?

gbdesign2023 commented 1 week ago

@afbora I have converted the video with a different code. Can you see it now?

nilshoerrmann commented 1 week ago

It seems like the panel is checking if the device is online but this doesn't take a local server into account. This can be very problematic if you are developing locally without internet connection because you cannot interact with the panel anymore.

gbdesign2023 commented 1 week ago

@nilshoerrmann My Mac is permanently connected to the Internet, as CDN content is also linked to my Kirby projects. And as I said: I never saw this message with Kirby 4.3.0.

afbora commented 1 week ago

Were there any other changes to files, plugins, settings, etc. when updating to 4.4.0?

bastianallgeier commented 1 week ago

@gbdesign2023 could you check in your browser console what you get when you type in panel.system.isLocal?

gbdesign2023 commented 1 week ago

@afbora Yes, I have changed a few things since the update, but more in terms of content than functionality. I have only updated the ‘johannschopplich/seo-audit’ plug-in.

@bastianallgeier ‘panel.system.isLocal’ How can I retrieve this information from the browser console? Since the offline hint only appears sporadically and is only displayed briefly, I don't see anything suspicious in the console afterwards.

bastianallgeier commented 1 week ago

@gbdesign2023

  1. open the developer tools
  2. go to console
  3. enter panel.system.isLocal and hit the Enter key

This should either return true or false as output.

It does not matter if the offline warning is shown at that point.

gbdesign2023 commented 1 week ago

@bastianallgeier Unfortunately, no value is displayed when entering panel.system.isLocal 01

Only this messages: 02

bastianallgeier commented 1 week ago

You've added it in the filter input. Please try adding it after the ">" symbol

nilshoerrmann commented 1 week ago

Different setup but maybe this helps aswell: I can trigger the offline message by simply switching my Wifi off. panel.system.isLocal always returns true. My guess is that the offline message does only take the connection into account and not if I'm in local context.

gbdesign2023 commented 1 week ago

Thanks for the tip. I only use the console to read, but not to send commands. I get ‘true’ back. What does this value mean?

Bildschirmfoto 2024-09-18 um 15 09 54
afbora commented 1 week ago

@gbdesign2023 Could you list the your app plugins, please? We can't still reproduce the issue and we'll try to reproduce.

bastianallgeier commented 6 days ago

We have a solution to only show the warning if the panel isn't installed locally. We plan to release a patch release on Monday.