Desktop Username password

[jigar-f]

@atavism You start reviewing this PR.

[atavism]

I think we may need to increase the height of the input fields on the sign in pages (cc @Derekf5)

[atavism]

I keep running into this issue switching tabs/navigating to different pages that causes the app to crash.. I can dig into it, but just wondering if you encountered anything like this?

signal 16 received but handler not on signal stack
mp.gsignal stack [0x14000084000 0x1400008c000], mp.g0 stack [0x16d374000 0x16d577000], sp=0x14004d87848
fatal error: non-Go code set up signal handler without SA_ONSTACK flag

runtime stack:
runtime.throw({0x15dd3980d?, 0x0?})
    runtime/panic.go:1023 +0x40 fp=0x14004d877a0 sp=0x14004d87770 pc=0x15d013100
runtime.sigNotOnStack(0x10, 0x14004d87848, 0x14000080008)
    runtime/signal_unix.go:1065 +0x118 fp=0x14004d877d0 sp=0x14004d877a0 pc=0x15d02db68
runtime.adjustSignalStack(0x10, 0x14000080008, 0x14004d87878)
    runtime/signal_unix.go:592 +0x25c fp=0x14004d87840 sp=0x14004d877d0 pc=0x15d02c9cc
runtime.sigtrampgo(0x10, 0x14004d879e0, 0x14004d87a48)
    runtime/signal_unix.go:480 +0x8c fp=0x14004d878c0 sp=0x14004d87840 pc=0x15d02c50c
runtime.sigtrampgo(0x10, 0x14004d879e0, 0x14004d87a48)
    <autogenerated>:1 +0x1c fp=0x14004d878f0 sp=0x14004d878c0 pc=0x15d05283c
runtime.sigtramp()
    runtime/sys_darwin_arm64.s:227 +0x4c fp=0x14004d879b0 sp=0x14004d878f0 pc=0x15d05130c

goroutine 34 gp=0x1400010c380 m=7 mp=0x14000108008 [syscall, locked to thread]:
runtime.goexit({})
    runtime/asm_arm64.s:1222 +0x4 fp=0x1400008cfe0 sp=0x1400008cfe0 pc=0x15d050244

goroutine 50 gp=0x140000021c0 m=nil [chan receive]:
runtime.gopark(0x14000461f38?, 0x15db39a9c?, 0x20?, 0x81?, 0x15e2bd0c0?)
    runtime/proc.go:402 +0xc8 fp=0x140001e2ec0 sp=0x140001e2ea0 pc=0x15d015f58
runtime.chanrecv(0x140000482a0, 0x14000461fa8, 0x1)
    runtime/chan.go:583 +0x404 fp=0x140001e2f40 sp=0x140001e2ec0 pc=0x15cfdfa84
runtime.chanrecv2(0x15e09ed60?, 0x14000808120?)
    runtime/chan.go:447 +0x14 fp=0x140001e2f70 sp=0x140001e2f40 pc=0x15cfdf664
github.com/getlantern/flashlight/v7/config.InitWithURLs.func2()
    github.com/getlantern/flashlight/v7@v7.6.87/config/initializer.go:81 +0x6c fp=0x140001e2fd0 sp=0x140001e2f70 pc=0x15db159bc
runtime.goexit({})
    runtime/asm_arm64.s:1222 +0x4 fp=0x140001e2fd0 sp=0x140001e2fd0 pc=0x15d050244
created by github.com/getlantern/flashlight/v7/config.InitWithURLs in goroutine 76
    github.com/getlantern/flashlight/v7@v7.6.87/config/initializer.go:80 +0x17c

[jigar-f]

I keep running into this issue switching tabs/navigating to different pages that causes the app to crash.. I can dig into it, but just wondering if you encountered anything like this?

signal 16 received but handler not on signal stack
mp.gsignal stack [0x14000084000 0x1400008c000], mp.g0 stack [0x16d374000 0x16d577000], sp=0x14004d87848
fatal error: non-Go code set up signal handler without SA_ONSTACK flag

runtime stack:
runtime.throw({0x15dd3980d?, 0x0?})
  runtime/panic.go:1023 +0x40 fp=0x14004d877a0 sp=0x14004d87770 pc=0x15d013100
runtime.sigNotOnStack(0x10, 0x14004d87848, 0x14000080008)
  runtime/signal_unix.go:1065 +0x118 fp=0x14004d877d0 sp=0x14004d877a0 pc=0x15d02db68
runtime.adjustSignalStack(0x10, 0x14000080008, 0x14004d87878)
  runtime/signal_unix.go:592 +0x25c fp=0x14004d87840 sp=0x14004d877d0 pc=0x15d02c9cc
runtime.sigtrampgo(0x10, 0x14004d879e0, 0x14004d87a48)
  runtime/signal_unix.go:480 +0x8c fp=0x14004d878c0 sp=0x14004d87840 pc=0x15d02c50c
runtime.sigtrampgo(0x10, 0x14004d879e0, 0x14004d87a48)
  <autogenerated>:1 +0x1c fp=0x14004d878f0 sp=0x14004d878c0 pc=0x15d05283c
runtime.sigtramp()
  runtime/sys_darwin_arm64.s:227 +0x4c fp=0x14004d879b0 sp=0x14004d878f0 pc=0x15d05130c

goroutine 34 gp=0x1400010c380 m=7 mp=0x14000108008 [syscall, locked to thread]:
runtime.goexit({})
  runtime/asm_arm64.s:1222 +0x4 fp=0x1400008cfe0 sp=0x1400008cfe0 pc=0x15d050244

goroutine 50 gp=0x140000021c0 m=nil [chan receive]:
runtime.gopark(0x14000461f38?, 0x15db39a9c?, 0x20?, 0x81?, 0x15e2bd0c0?)
  runtime/proc.go:402 +0xc8 fp=0x140001e2ec0 sp=0x140001e2ea0 pc=0x15d015f58
runtime.chanrecv(0x140000482a0, 0x14000461fa8, 0x1)
  runtime/chan.go:583 +0x404 fp=0x140001e2f40 sp=0x140001e2ec0 pc=0x15cfdfa84
runtime.chanrecv2(0x15e09ed60?, 0x14000808120?)
  runtime/chan.go:447 +0x14 fp=0x140001e2f70 sp=0x140001e2f40 pc=0x15cfdf664
github.com/getlantern/flashlight/v7/config.InitWithURLs.func2()
  github.com/getlantern/flashlight/v7@v7.6.87/config/initializer.go:81 +0x6c fp=0x140001e2fd0 sp=0x140001e2f70 pc=0x15db159bc
runtime.goexit({})
  runtime/asm_arm64.s:1222 +0x4 fp=0x140001e2fd0 sp=0x140001e2fd0 pc=0x15d050244
created by github.com/getlantern/flashlight/v7/config.InitWithURLs in goroutine 76
  github.com/getlantern/flashlight/v7@v7.6.87/config/initializer.go:80 +0x17c

@atavism I am getting this issue multiple times at random places in the app, I am not sure what's going on here, If you take a look, That would be great, There is something related to go signals.

Also fyi-: this does not happen in the release build.

[jigar-f]

@atavism thanks for approving, Did you able to find out about the crash?

[atavism]

@jigar-f I haven't been able to figure out what's causing the app to crash. I actually haven't experienced the same issue in awhile testing the latest changes. So I think we can just wait to see if it resurfaces

[atavism]

I discovered an issue where it looks like the timer in the VPNChangeNotifier isn't being stopped when it reaches the max number of ticks..

Jul 16 16:34:43.809 - 0m20s DEBUG app.settings: settings.go:670 Could not get value for userPro
flutter: startup status proxy true config true success false
flutter: flashlight fail initialized
Jul 16 16:34:44.810 - 0m21s DEBUG app.settings: settings.go:670 Could not get value for userPro
flutter: startup status proxy true config true success false
flutter: flashlight fail initialized
Jul 16 16:34:45.809 - 0m22s DEBUG app.settings: settings.go:670 Could not get value for userPro
flutter: startup status proxy true config true success false
flutter: flashlight fail initialized
Jul 16 16:34:46.810 - 0m23s DEBUG app.settings: settings.go:670 Could not get value for userPro
flutter: startup status proxy true config true success false
flutter: flashlight fail initialized
Jul 16 16:34:47.810 - 0m24s DEBUG app.settings: settings.go:670 Could not get value for userPro
flutter: startup status proxy true config true success false
flutter: flashlight fail initialized
Jul 16 16:34:48.810 - 0m25s DEBUG app.settings: settings.go:670 Could not get value for userPro
flutter: startup status proxy true config true success false
flutter: flashlight fail initialized

[jigar-f]

t

This is not an issue, We run the timer till the flashlight is initialized.

[jigar-f]

signal 16 received but handler not on signal stack
mp.gsignal stack [0x14000084000 0x1400008c000], mp.g0 stack [0x16ba88000 0x16bc8b000], sp=0x14000857678
fatal error: non-Go code set up signal handler without SA_ONSTACK flag

@atavism I am still getting crash, Any idea whats going on?

[atavism]

@atavism I am still getting crash, Any idea whats going on?

No, I am still having trouble getting the app to crash again myself. What are you doing just before the crash happens -- switching tabs, turning the VPN on, etc? It might be helpful to add additional logging to try to pinpoint where the crash is happening

[jigar-f]

It crashes for me at random places, I have already added some logging to track it down.

[jigar-f]

@atavism This might be the issue

[jigar-f]

@atavism All changes are added, SHould I go ahead and merge this?

[atavism]

@atavism All changes are added, SHould I go ahead and merge this?

Thanks for making those changes! Sounds great! Merging..