search

getlantern / lantern-client

Lantern Client code
GNU General Public License v3.0
14 stars 3 forks source link

Updates to how we subscribe to websocket changes #1150

Closed atavism closed 3 months ago

atavism commented 3 months ago

@jigar-f This one is still a work-in-progress, but feel free to take it for a spin if you get a chance and let me know how it works for you

jigar-f commented 3 months ago

@atavism Thanks, I'll take it for a spin next week.

atavism commented 3 months ago

@jigar-f Thanks!! This one is working really well for me (there's a couple areas I haven't tested yet like payment redirect and reporting an issue) so I'm curious how it works for you

jigar-f commented 3 months ago

I see there are a few places in sessionModel we are using ffiValueBuilder, I think we need migrated that as well

atavism commented 3 months ago

I see there are a few places in sessionModel we are using ffiValueBuilder, I think we need migrated that as well

I removed the remaining instances of it except for chat where we are just setting some default values