getmanfred / mac

Manfred Awesomic CV
Creative Commons Attribution Share Alike 4.0 International
580 stars 36 forks source link

Problem when executing Python Generation Script #26

Open ignapzs opened 1 year ago

ignapzs commented 1 year ago

After reading the scripts README, and proceed to create the virtual environment with all the required dependencies, I came across the following problem:

When executing ❯ python ./jsonschema_generator.py ../../schema/schema.json -o example1.json

then the following error appears

Traceback (most recent call last): [....] File "[......]/mac/scripts/python_validator/./jsonschema_generator.py", line 52, in generate_dict generator = self.get_generator(v["type"]) KeyError: 'type'

Could this be related to each of the different element definitions like #/$defs/person or #/$defs/location ?

ydarias commented 1 year ago

This issue is fixed by #24

ignapzs commented 1 year ago

Hi @ydarias . I'm afraid to say that #24 does not fix this problem. I only submitted a PR ( #25 ) to fix #24. Problem still remains.

I just tried to explain current problem with generation script on the same way as validation one. Even one guess, based on the given returned message, as I only got basic Python skills.

My fault if I wasn't clear on my messages :/

ydarias commented 1 year ago

No problem @ignapzs I will keep it open until we fix it.

And no worries, thank you very much for your help anyway ^_^