search

getodk / aggregate

ODK Aggregate is a Java server that stores, analyzes, and presents survey data collected using ODK Collect. Contribute and make the world a better place! ✨🗄✨
https://docs.opendatakit.org/aggregate-intro/
Other
74 stars 228 forks source link

Issue 457 relax json publisher url validation #458

Closed ggalmazor closed 5 years ago

ggalmazor commented 5 years ago

Closes #457

What has been done to verify that this works as intended?

Run Aggregate locally and try out the new URL validation with URLS that start with http://, https:// or otherwise.

Why is this the best possible solution? Were any other approaches considered?

This is a super narrow change. No alternatives where considered.

Are there any risks to merging this code? If so, what are they?

Nope.

Do we need any specific form for testing your changes? If so, please attach one

No.

Does this change require updates to documentation? If so, please file an issue at https://github.com/opendatakit/docs/issues/new and include the link below.

No.

kkrawczyk123 commented 5 years ago

Tested with success! Verified on tomcat instance.

@opendatakit-bot unlabel "needs testing" @opendatakit-bot label "behavior verified"