getodk / aggregate

ODK Aggregate is a Java server that stores, analyzes, and presents survey data collected using ODK Collect. Contribute and make the world a better place! ✨🗄✨
https://docs.opendatakit.org/aggregate-intro/
Other
74 stars 227 forks source link

Aggregate loses data if submission batches are not sequential #77

Open getodk-bot opened 7 years ago

getodk-bot commented 7 years ago

Issue by MartijnR Wednesday Feb 03, 2016 at 18:21 GMT Originally opened as https://github.com/opendatakit/opendatakit/issues/1195 (0 comment(s))


Note: I tested this with ODK Aggregate v1.4.5. My user experienced this issue in v1.4.6. If Aggregate's (batches) submission handling has been updated in v1.4.7, please accept my apologies and discard this issue. (I don't seem to be capable of updating Aggregate any more).

If a submission contains two 9Mb images (I used the same image with different filenames), the submission is split up into 2 batches. I found that if both batches are sent in close succession, i.e. the second batch is sent before the first batch submission has received a response from Aggregate, Aggregate returns a 201 response for both batches. This indicates to the client the record was received successfully.

screen shot 2016-02-02 at 4 31 47 pm

It seems that the record is not available in Aggregate though and I see an error like this:

screen shot 2016-02-02 at 2 27 47 pm

The OpenRosa submission spec doesn't specify that these batches need to be sent sequentially. Ona doesn't require this either (and presumably nor do KoBo and Formhub).

As a workaround Enketo now sends batches sequentially. However, considering the serious consequences (permanent data loss?) of this bug, I wanted to report it.

jbeorse commented 7 years ago

This message was created automatically by mail delivery software.

A message that you sent could not be delivered to one or more of its recipients. This is a temporary error. The following address(es) deferred:

jeffisveryhungry@gmail.com Domain beorse.net has exceeded the max emails per hour (272/250 (108%)) allowed. Message will be reattempted later

------- This is a copy of the message, including all the headers. ------ ------ The body of the message is 6531 characters long; only the first ------ 5000 or so are included here. Received: from github-smtp2-ext8.iad.github.net ([192.30.252.199]:36556 helo=github-smtp2a-ext-cp1-prd.iad.github.net) by hp159.hostpapa.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from noreply@github.com) id 1dgMCd-000ea0-V3 for Jeff@Beorse.net; Fri, 11 Aug 2017 22:31:04 -0400 Date: Fri, 11 Aug 2017 19:30:24 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1502505024; bh=4kWxS5hSuU2/U51Oym+y+B8o+zsOG7YlVkQ01ZbmGCA=; h=From:Reply-To:To:Cc:Subject:List-ID:List-Archive:List-Post: List-Unsubscribe:From; b=0k1LRmq+rOUzMuyiJKf9s51My6j2lykBGJGQjJrdOHIJtC6B8QPdFYoVL7oo8rAqv B9Sos1Y2PWpHZAGueGjVguLUZO3ZsgyDJCIsPEzrW/VnfJuCIsI3p1bpEcyju6h3t/ +ezNDZERHtJ8sgZ41//sNRejzDLytRGWthw/znmk= From: Open Data Kit notifications@github.com Reply-To: opendatakit/aggregate reply@reply.github.com To: opendatakit/aggregate aggregate@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Message-ID: opendatakit/aggregate/issues/77@github.com Subject: [opendatakit/aggregate] Aggregate loses data if submission batches are not sequential (#77) Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_598e6840567ce_55d53ff6c7903c301112c8"; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: opendatakit-bot X-GitHub-Recipient: jbeorse X-GitHub-Reason: subscribed List-ID: opendatakit/aggregate List-Archive: https://github.com/opendatakit/aggregate List-Post: mailto:reply@reply.github.com List-Unsubscribe: mailto:unsub+000519af421f2872f1dfdd52192b469e327adcf2f611695892cf0000000115a62a4092a169ce0ee3627b@reply.github.com, https://github.com/notifications/unsubscribe/AAUZr4C3FuPKTpTMAf9WFR3VuVQITNmwks5sXQ5AgaJpZM4O1SQ1 X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: Jeff@Beorse.net

----==_mimepart_598e6840567ce_55d53ff6c7903c301112c8 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit

Issue by MartijnR Wednesday Feb 03, 2016 at 18:21 GMT Originally opened as https://github.com/opendatakit/opendatakit/issues/1195 (0 comment(s))


Note: I tested this with ODK Aggregate v1.4.5. My user experienced this issue in v1.4.6. If Aggregate's (batches) submission handling has been updated in v1.4.7, please accept my apologies and discard this issue. (I don't seem to be capable of updating Aggregate any more).

If a submission contains two 9Mb images (I used the same image with different filenames), the submission is split up into 2 batches. I found that if both batches are sent in close succession, i.e. the second batch is sent before the first batch submission has received a response from Aggregate, Aggregate returns a 201 response for both batches. This indicates to the client the record was received successfully.

screen shot 2016-02-02 at 4 31 47 pm

It seems that the record is not available in Aggregate though and I see an error like this:

screen shot 2016-02-02 at 2 27 47 pm

The OpenRosa submission spec doesn't specify that these batches need to be sent sequentially. Ona doesn't require this either (and presumably nor do KoBo and Formhub).

As a workaround Enketo now sends batches sequentially. However, considering the serious consequences (permanent data loss?) of this bug, I wanted to report it.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/opendatakit/aggregate/issues/77 ----==_mimepart_598e6840567ce_55d53ff6c7903c301112c8 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Issue by MartijnR
Wednesday Feb 03, 2016 at 18:21 GMT
Originally opened as opendatakit/opendatakit#1195 (0 comment(s))


Note: I tested this with ODK Aggregate v1.4.5. My user experienced this issue in v1.4.6. If Aggregate's (batches) submission handling has been updated in v1.4.7, please accept my apologies and discard this issue. (I don't seem to be capable of updating Aggregate any more).

If a submission contains two 9Mb images (I used the same image with different filenames), the submission is split up into 2 batches. I found that if both batches are sent in close succession, i.e. the second batch is sent before the first batch submission has received a response from Aggregate, Aggregate returns a 201 response for both batches. This indicates to the client the record was received successfully.

screen shot 2016-02-02 at 4 31 47 pm

It seems that the record is not available in Aggregate though and I see an error like this:

screen shot 2016-02-02 at 2 27 47 pm

The OpenRosa submission spec doesn't specify that these batches need to be sent sequentially. Ona doesn't require this either (and presumably nor do KoBo and Formhub).

As a workaround Enketo now sends batches sequentially. However, considering the serious consequences (permanent data loss?) of this bug, I wanted to report it.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on Gi

ggalmazor commented 6 years ago

Attention! We're housekeeping! This issue will automatically be closed if no feedback is received in one week.

If this issue is important to you or you can provide more information about it, please, do so as soon as possible :)