ODK Collect is an Android app for filling out forms. It's been used to collect billions of data points in challenging environments around the world. Contribute and make the world a better place! ✨📋✨
Why is this the best possible solution? Were any other approaches considered?
The problem here was a bug in a recursive function that returned a wrong (null) value too early.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
We should test forms with geopoints (those that display the map icon in the form list) under different configurations. In this case, the issue was that while the geopoint existed, the form had two groups, and it was placed in the second one. It would be helpful to create several forms with multiple groups, including nested ones, to thoroughly test these scenarios.
Do we need any specific form for testing your changes? If so, please attach one.
No.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
[x] added or modified tests for any new or changed behavior
[x] run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
[x] added a comment above any new strings describing it for translators
[x] added any new strings with date formatting to DateFormatsTest
[x] verified that any code or assets from external sources are properly credited in comments and/or in the about file.
Closes #6450
Why is this the best possible solution? Were any other approaches considered?
The problem here was a bug in a recursive function that returned a wrong (null) value too early.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
We should test forms with geopoints (those that display the map icon in the form list) under different configurations. In this case, the issue was that while the geopoint existed, the form had two groups, and it was placed in the second one. It would be helpful to create several forms with multiple groups, including nested ones, to thoroughly test these scenarios.
Do we need any specific form for testing your changes? If so, please attach one.
No.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest
(or./gradlew testLab
) and confirmed all checks still passDateFormatsTest