getodk / collect

ODK Collect is an Android app for filling out forms. It's been used to collect billions of data points in challenging environments around the world. Contribute and make the world a better place! ✨📋✨
https://docs.getodk.org/collect-intro
Other
719 stars 1.38k forks source link

Remove redundant files cleaning during resetting saved forms #6477

Closed grzesiek2010 closed 1 month ago

grzesiek2010 commented 1 month ago

Closes #6475

Why is this the best possible solution? Were any other approaches considered?

We don't need the file cleaning that removes all instance directories, as when we reset specific instances (those that can be deleted), their files are removed automatically. See: https://github.com/getodk/collect/blob/master/collect_app/src/main/java/org/odk/collect/android/database/instances/DatabaseInstancesRepository.java#L153

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

We should test it in the same way as this pull request, as this is a fix for that specific PR.

Do we need any specific form for testing your changes? If so, please attach one.

No.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

WKobus commented 3 weeks ago

Tested with Success

Verified on device with Android 15

Verified cases:

dbemke commented 3 weeks ago

Tested with Success

Verified on device with Android 10