search

getpinga / tide

Tide client area theme for FOSSBilling
MIT License
16 stars 10 forks source link

Upcoming changes with FOSSBilling #38

Closed BelleNottelling closed 6 months ago

BelleNottelling commented 7 months ago

Hi, @getpinga I hope you are doing well. I wanted to let you know that if all goes to plan we intend to be publishing FOSSBilling version 0.6.0 about 1 week after PHP 8.3 reaches GA (should be a few weeks from now). With this release, some backwards incompatible changes will be coming out which will effect the Tide theme. There are also some new features which might be nice to Tide to support, however they aren't needed for compatibility. The fully up-to-date changes are here: https://fossbilling.org/docs/changelog#060-wip

In your case, I believe the only thing that will be necessary to get things working once again is replace references to BB_URL with SYSTEM_URL, however I have not investigated.

BelleNottelling commented 7 months ago

Having done further work to catch-up our own theme work from ~4 month ago, there's a bit more required to fully migrate it.

At the absolute minimum the constant needs to be updated, however there's still changes needed to reflect newly added features. Additionally, there are changes required to reflect the fact that the KB and support modules got merged and without it the KB will be unusable with Tide.

There is also the new password reset template that was originally introduced with 0.5.6, however our base templates are now all using Bootstrap 5 so it's entirely likely that template would still look fine once loaded inside of this theme (Tabler is built on Bootstrap 5 so they should be mostly interchangeable without too much headache)

evilmc commented 6 months ago

Hi @getpinga , please update your theme to work with latest FB. Thanks!

gilesytheking commented 6 months ago

@evilmc I have patched the BB_URL issue which gets the template working again with V6, but that's all. There are still some items that need to be worked on to bring tide up to date with the latest changes made in Foss.

You can download the patched version from my fork here - https://github.com/gilesytheking/tide

Hope that helps.

getpinga commented 6 months ago

Thanks a lot everyone, the PR has been merged with the main branch too. Will test now with the last FOSSBilling and make any further changes if needed.

BelleNottelling commented 6 months ago

FYI @getpinga this is still incomplete as neither of the merged PRs accounted for the fact that the the KB and support modules were merged

evilmc commented 6 months ago

Latest update have 404 error when I click on https://domain.com/signup

getpinga commented 5 months ago

FYI @getpinga this is still incomplete as neither of the merged PRs accounted for the fact that the the KB and support modules were merged

Thanks a lot. Now it seems to have it fixed.

getpinga commented 5 months ago

Latest update have 404 error when I click on https://domain.com/signup

Thanks, the latest merged PRs fixed this.