getsentry / action-release

GitHub Action for creating a release on Sentry
Apache License 2.0
446 stars 53 forks source link

Update `v1` tag to latest release #114

Closed jcarvalho closed 2 years ago

jcarvalho commented 2 years ago

Hi.

Just noticed that version 1.2.1 is out, but the v1 tag is still pointing at version 1.1.6.

Is this tag not officially supported (and thus we should explicitly specify the version), or is 1.2.1 not yet ready for use?

armenzg commented 2 years ago

We're making everyone follow the v1 tag rather than have a tag per version.

jcarvalho commented 2 years ago

In that case, could we get the tag updated to point to the latest release, or is it not yet ready for Production use?

armenzg commented 2 years ago

Thanks for pointing that out. I am still becoming familiar with the release process of this.

@mattgauntseo-sentry I believe we need to tag the latest changeset for the change to be live.

Is pushing this tag change all it takes?

git tag -f v1
Updated tag 'v1' (was 744e4b2)
git show
commit bd5f874fcda966ba48139b0140fb3ec0cb3aabdd (HEAD -> master, tag: v1.2.1, tag: v1, origin/master, origin/HEAD)
Author: Matt Gaunt-Seo @ Sentry.io <112419115+mattgauntseo-sentry@users.noreply.github.com>
Date:   Thu Nov 3 12:32:59 2022 -0700

    Update version to 1.2.1 (#112)

diff --git a/package.json b/package.json
index 8b80fba..8295d1e 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "action-release",
-  "version": "1.2.0",
+  "version": "1.2.1",
   "private": true,
   "description": "GitHub Action for creating a release on Sentry",
   "main": "dist/index.js",
mattgauntseo-sentry commented 2 years ago

Ah apologies, I naively thought GitHub had some magic here since I didn't see a tag v1 in the GitHub UI.

But yes pushing the tag tag as you have there makes sense.

mattgauntseo-sentry commented 2 years ago

Tag has been updated: https://github.com/getsentry/action-release/releases/tag/v1

PR is out to update release instructions so the next release will, hopefully, happen at the same time as the release.

jcarvalho commented 2 years ago

Awesome, can confirm the new version is being picked up! Thanks for fixing this.

I see you linked the PR to this issue, so will leave it open until the PR gets merged.

chillyistkult commented 2 years ago

It broke for me after being stable for the past 3 years any idea what's wrong?

- name: Create sentry release
        if: ${{ startsWith(github.ref, 'refs/tags/v') }}
        uses: getsentry/action-release@v1
        env:
          SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_AUTH_TOKEN }}
          SENTRY_ORG: xxx
          SENTRY_PROJECT: ${{ secrets.SENTRY_PROJECT }}
          RELEASE_VERSION: ${{ format('{0}-{1}', secrets.SENTRY_PROJECT, env.VERSION) }}
        with:
          environment: production
          sourcemaps: build
          version: ${{ format('{0}-{1}', secrets.SENTRY_PROJECT, env.VERSION) }}
Bildschirmfoto 2022-11-09 um 11 43 10
armenzg commented 2 years ago

It broke for me after being stable for the past 3 years any idea what's wrong?

- name: Create sentry release
        if: ${{ startsWith(github.ref, 'refs/tags/v') }}
        uses: getsentry/action-release@v1
        env:
          SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_AUTH_TOKEN }}
          SENTRY_ORG: xxx
          SENTRY_PROJECT: ${{ secrets.SENTRY_PROJECT }}
          RELEASE_VERSION: ${{ format('{0}-{1}', secrets.SENTRY_PROJECT, env.VERSION) }}
        with:
          environment: production
          sourcemaps: build
          version: ${{ format('{0}-{1}', secrets.SENTRY_PROJECT, env.VERSION) }}
Bildschirmfoto 2022-11-09 um 11 43 10

Are you on GH Enterprise? It should be able to reach the image: https://github.com/getsentry/action-release/pkgs/container/action-release-image

docker pull ghcr.io/getsentry/action-release-image:latest
latest: Pulling from getsentry/action-release-image
df9b9388f04a: Already exists
3bf6d7380205: Already exists
7939e601ee5e: Already exists
31f0fb9de071: Already exists
134ccfb6d0c0: Pull complete
ed314acfdc9d: Pull complete
097c85f5736c: Pull complete
2e6ed543eabd: Pull complete
64312a9fc0fb: Pull complete
4f4fb700ef54: Pull complete
Digest: sha256:0a0b4e487d8f98e604967b0a485dc980cb62b3f2c4737f4225e07a49a48b3066
Status: Downloaded newer image for ghcr.io/getsentry/action-release-image:latest
ghcr.io/getsentry/action-release-image:latest
chillyistkult commented 2 years ago

Thanks turned out somehow the docker login on the server expired after years

armenzg commented 2 years ago

Phew!