getsentry / action-release

GitHub Action for creating a release on Sentry
Apache License 2.0
446 stars 53 forks source link

Wrong commit selection #139

Open MaximeLaurenty opened 1 year ago

MaximeLaurenty commented 1 year ago

Github Sentry Action Release Bug Report

Environment

How do you use this action? Standard Github runners, container built on top of archlinux:base

Which version of the action? getsentry/action-release@v1.3.1

Steps to Reproduce

  1. Setup action in our CI, triggered on every commit to master
    - name: Create Sentry release
    uses: getsentry/action-release@v1.3.1
    env:
    SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_AUTH_TOKEN }}
    SENTRY_ORG: ${{ secrets.SENTRY_ORG }}
    with:
    environment: prod
    projects: frontend
    sourcemaps: frontend
    version: ${{ github.sha }}
    dist: ${{ github.sha }}
    url_prefix: "~"
  2. Make multiples commits to master
  3. Check info about releases into Sentry

Expected Result

Have only 1 commit in every release.

Actual Result

Most of the time, commits are properly set within releases (just 1), but sometimes a discrepancy happens and a release contains multiple commits (for which releases already exist): see here commits in the latest release (including previous fe51918): Screenshot 2023-04-07 at 15 36 02 - sentry commit list see here the release just before (which includes fe51918): Screenshot 2023-04-07 at 15 40 31 sentry release list links to sentry if you have access: erroneous release, right release before that & list of our releases There is no relevant info in the logs of the action.

mmospanenko commented 1 year ago

maybe it requires more commits in current session?

      - uses: actions/checkout@v3
        with:
          fetch-depth: 0
MaximeLaurenty commented 1 year ago

How would adding more commits to the available history in github action lead to less commits on sentry releases? Fyi all our releases already have at least one commit. (and in our case: each release should have exactly one commit given we create a release and deploy after every commit)