fix(github): Increase artifact polling interval and max retries

getsentry / craft

The universal Sentry release CLI 🚀

MIT License

133 stars 15 forks source link

fix(github): Increase artifact polling interval and max retries #484

Closed Lms24 closed 1 year ago

Lms24 commented 1 year ago

As outlined in #482 by @BYK we should increase the time we wait for the build artifacts so that the publishing process doesn't fail if GH didn't upload artifacts within 30s.

closes #482

BYK commented 1 year ago

Looks like you need to update the test snapshots now:

yarn test -u

Lms24 commented 1 year ago

Hmm I don't know why the pr-check job is failing. Anyone have an idea why/how to fix?

Lms24 commented 1 year ago

I'd love to 🚢 but I can't merge as long as the pr-check job is failing. I have 0 context around google cloud build and the logs don't really help me (I'm probably missing something). Any ideas what could be going wrong?

asottile-sentry commented 1 year ago

I killed cloudbuild so this should be better now

Lms24 commented 1 year ago

Closing due to https://github.com/getsentry/craft/issues/482#issuecomment-1670951174