search

getsentry / craft

The universal Sentry release CLI 🚀
MIT License
133 stars 15 forks source link

fix(brew): Replace version in artifact names with '__VERSION__' to access checksums from mustache #488

Closed romtsn closed 1 year ago

romtsn commented 1 year ago

This PR is a prerequisite for publishing sentry-wizard to brew (see https://github.com/getsentry/sentry-wizard/pull/406)

When artifact names contain versions (e.g. sentry-wizard-v3.10.0.tgz), it's not possible to access their checksums when publishing to brew, because mustache does not support nested variables. The template for brew formula would have to look something like this, but I couldn't find how to make it work for mustache:

sha256 "{{checksums.sentry-wizard-v{{version}}.tgz}}"

So this PR is simply replacing the version with __VERSION__, if it appears to be in the name of the artifact, when building the checksums dictionary.

Also updated readme to clarify the restrictions on the keys for checksums for the brew target.

Part of https://github.com/getsentry/sentry-wizard/issues/346