search

getsentry / profiling-node

The code for this repo now lives in https://github.com/getsentry/sentry-javascript/tree/develop/packages/profiling-node
MIT License
29 stars 10 forks source link

fix: cleanup timer and reuse exports #229

Closed JonasBa closed 8 months ago

JonasBa commented 8 months ago

Fix #228 (tested by linking the built module to the reproducible code from issue).

anonrig commented 8 months ago

Somehow, we have a lint issue, but GitHub workflow doesn't give us a warning?

JonasBa commented 8 months ago

I'm going to check, it should be failing, but I also noticed some formatting changes were applied that shouldn't be

JonasBa commented 8 months ago

@anonrig let me fix the linter separately, I want to merge this so we fix the issue and unblock the user. I'll followup with the linter change