search

getsentry / raven-go

Sentry client in Go
https://sentry.io
BSD 3-Clause "New" or "Revised" License
561 stars 148 forks source link

[#111][#125] Send custom extra data #134

Closed syndbg closed 6 years ago

syndbg commented 7 years ago

The API changes are considerable and the docs at https://docs.sentry.io/clients/go/ will need to be updated. I'm going to update them too. WIP on that.

The PR imo is not ready for merge. I'll try and update the docs wherever needed.

Docs updated, I think we're good to go?

@mattrobenolt @zkanda

syndbg commented 7 years ago

Ping, anyone? @mattrobenolt

rollcat commented 7 years ago

Sorry for the spam, but this is relevant to my interests.

If breaking the API is a big concern, perhaps I could work on a variant with new *WithExtra methods? CaptureErrorWithExtra etc.

syndbg commented 7 years ago

@mattrobenolt ping

mattrobenolt commented 7 years ago

If breaking the API is a big concern, perhaps I could work on a variant with new *WithExtra methods? CaptureErrorWithExtra etc.

Sorry for the delay here, I'd absolutely love to do that instead of breaking all the existing APIs.

syndbg commented 7 years ago

@mattrobenolt Sure, could do that in the same PR.

syndbg commented 7 years ago

@mattrobenolt Sorry for the delay, I've updated the PR. Added *Extra functions.

syndbg commented 7 years ago

@mattrobenolt Ping?

knabben commented 6 years ago

Fixed on #190