search

getsentry / raven-go

Sentry client in Go
https://sentry.io
BSD 3-Clause "New" or "Revised" License
561 stars 148 forks source link

Add AddExtra support. #146

Closed Colstuwjx closed 6 years ago

Colstuwjx commented 7 years ago

As we need some extra context to debug problems, AddExtra is needed.

Colstuwjx commented 7 years ago

Hi @mattrobenolt

It seems that we have some PR( like #74 ) that try to add extra method or full extra context support. We have been waited it for one year ago, and I think it's time to merge extra context support to upstream.

jheth commented 6 years ago

Can this be closed now that #190 is merged?

Colstuwjx commented 6 years ago

Yes, I think the differences between adding extra within Capture... method and NewPacketWithExtra... is an acceptable change, so cool for that!