search

getsentry / raven-python

Raven is the legacy Python client for Sentry (getsentry.com) — replaced by sentry-python
https://sentry.io
BSD 3-Clause "New" or "Revised" License
1.68k stars 657 forks source link

Allow dict-style logging in breadcrumbs processing #1252

Closed rakai93 closed 6 years ago

rakai93 commented 6 years ago

This commit changes the breadcumbs processor to be able to handle dict-style logging properly, e.g. logger.info('Hello %(who)s', {'who': 'world'}). Prior to this change, breadcrumbs shown in Sentry were not interpolated and thus hard to follow.

rakai93 commented 6 years ago

Seems like the travis CI jobs is broken (correct me if I'm wong), but tests are failing unrelated to this change. Can someone please have a look?

ashwoods commented 6 years ago

@rakai93 mind rebasing from master?

rakai93 commented 6 years ago

@ashwoods Thank you, I merged master and now the checks pass!