search

getsentry / self-hosted

Sentry, feature-complete and packaged up for low-volume deployments and proofs-of-concept
https://develop.sentry.dev/self-hosted/
Other
7.95k stars 1.78k forks source link

Missing Discover Icon #3323

Open JonPurvis opened 2 months ago

JonPurvis commented 2 months ago

Self-Hosted Version

24.8.0

CPU Architecture

x86_64

Docker Version

24.0.7

Docker Compose Version

2.29.2

Steps to Reproduce

  1. Go to Dashboard
  2. Look at Discover Link in menu
  3. You should see a dot instead of an icon

I'm running on an Errors Only Sentry instance, not sure if that has any bearing.

Expected Result

In previous versions of Sentry, this is a telescope.

Actual Result

Image

Event ID

No response

hubertdeng123 commented 2 months ago

Thanks for reporting this! I believe this regression was introduced when we reworked the sidebar for Sentry

aldy505 commented 2 months ago

Just dug around. This is not a bug, see this line:

https://github.com/getsentry/sentry/blob/fa5c96d58debe2db4f3b1c8896f6944988d73904/static/app/components/sidebar/index.tsx#L243

Compared to the previous change that has <IconTelescope> component on it:

https://github.com/getsentry/sentry/blob/ccb3c648d0d065bfe84840d1956fb0a9f5ab3544/static/app/components/sidebar/index.tsx#L236

It's intended, but it'd surely be nicer if it's a telescope icon though.