getsentry / sentry-dart

Sentry SDK for Dart and Flutter
https://sentry.io/for/flutter/
MIT License
766 stars 239 forks source link

Remove duplicate tests in sentry_client_test.dart #2378

Closed denrase closed 1 month ago

denrase commented 1 month ago

skip-changelog

Remove duplicate tests in sentry_client_test.dart

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.64%. Comparing base (7954fb3) to head (19a02e2). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2378 +/- ## ========================================== + Coverage 84.72% 85.64% +0.91% ========================================== Files 253 240 -13 Lines 9083 8688 -395 ========================================== - Hits 7696 7441 -255 + Misses 1387 1247 -140 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

denrase commented 1 month ago

@buenaflor Coverage should stay the same, as these were dupes. But lets wait for CI to finish.

github-actions[bot] commented 1 month ago

iOS Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 1225.20 ms 1244.63 ms 19.43 ms
Size 8.38 MiB 9.75 MiB 1.37 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
613760b51612c5874f586dd29349e387b289c8cd 1263.10 ms 1277.27 ms 14.16 ms
2966d88d828c6e2604b15b95f0d0d958acc2cc68 1251.76 ms 1270.21 ms 18.46 ms
f172c4de11085065216c98124283effeb0d0f15e 1350.66 ms 1408.49 ms 57.83 ms
0a23f9840336da9128fd8f15f1a373563820df64 1252.98 ms 1276.76 ms 23.78 ms
6daa837b45789cb21c8bb0075c58ad6f5e5e83b6 1250.42 ms 1265.60 ms 15.18 ms
f79eecfc96c81e45b312c72aea32e4943329666b 1210.25 ms 1221.65 ms 11.40 ms
7954fb356f96f17127c41230af433bc9ce01233c 1247.20 ms 1272.15 ms 24.94 ms
5112c69cbabc27fdee43278e7fae250aa56d0120 1272.76 ms 1293.37 ms 20.61 ms
bf4aed726e9adcfe8b364aef9d0870dd2c4ad5fe 1274.63 ms 1286.48 ms 11.85 ms
24f71aae695d5763d7ad28592191d95841f59b40 1267.47 ms 1272.00 ms 4.53 ms

App size

Revision Plain With Sentry Diff
613760b51612c5874f586dd29349e387b289c8cd 8.15 MiB 9.13 MiB 1000.46 KiB
2966d88d828c6e2604b15b95f0d0d958acc2cc68 8.32 MiB 9.38 MiB 1.06 MiB
f172c4de11085065216c98124283effeb0d0f15e 8.33 MiB 9.62 MiB 1.29 MiB
0a23f9840336da9128fd8f15f1a373563820df64 8.10 MiB 9.18 MiB 1.08 MiB
6daa837b45789cb21c8bb0075c58ad6f5e5e83b6 8.33 MiB 9.40 MiB 1.07 MiB
f79eecfc96c81e45b312c72aea32e4943329666b 8.29 MiB 9.36 MiB 1.07 MiB
7954fb356f96f17127c41230af433bc9ce01233c 8.38 MiB 9.75 MiB 1.37 MiB
5112c69cbabc27fdee43278e7fae250aa56d0120 8.16 MiB 9.17 MiB 1.01 MiB
bf4aed726e9adcfe8b364aef9d0870dd2c4ad5fe 8.10 MiB 9.17 MiB 1.08 MiB
24f71aae695d5763d7ad28592191d95841f59b40 8.10 MiB 9.16 MiB 1.07 MiB
github-actions[bot] commented 1 month ago

Android Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 536.70 ms 597.36 ms 60.66 ms
Size 6.49 MiB 7.57 MiB 1.08 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
8a111a931e3ce73766e66f9be34ceb22c3a4e2cc 496.27 ms 520.57 ms 24.31 ms
5f2f77becb74ef2093007f845ec89eed6c5a031d 429.06 ms 507.74 ms 78.68 ms
7ec9238637dbe38b6170da172bc0650eaa157885 414.02 ms 513.94 ms 99.91 ms
abfcdb5365060597e8a7479eafb93c0cfb6a210b 416.55 ms 498.88 ms 82.33 ms
26e955b4fd95d08090ceb4efc74631e20000a553 369.52 ms 458.60 ms 89.07 ms
7f75f32d9707c5a5abdb869a9eb5de05dd91bed8 347.36 ms 419.58 ms 72.22 ms
7d5e695652556d2c9b46f3e78316841a831c77b5 433.45 ms 485.11 ms 51.66 ms
cdf717208af3df3b373ff78e404cc7da02e49a29 348.54 ms 390.81 ms 42.27 ms
5aba4171c641227176fb08f4a73fc95f620c4a42 355.78 ms 450.39 ms 94.61 ms
3334ac176f15a6d39b435960620ea9a4919aae79 303.98 ms 366.65 ms 62.67 ms

App size

Revision Plain With Sentry Diff
8a111a931e3ce73766e66f9be34ceb22c3a4e2cc 6.49 MiB 7.56 MiB 1.07 MiB
5f2f77becb74ef2093007f845ec89eed6c5a031d 6.35 MiB 7.40 MiB 1.05 MiB
7ec9238637dbe38b6170da172bc0650eaa157885 6.35 MiB 7.42 MiB 1.06 MiB
abfcdb5365060597e8a7479eafb93c0cfb6a210b 6.35 MiB 7.40 MiB 1.05 MiB
26e955b4fd95d08090ceb4efc74631e20000a553 6.27 MiB 7.20 MiB 956.49 KiB
7f75f32d9707c5a5abdb869a9eb5de05dd91bed8 6.26 MiB 7.20 MiB 959.18 KiB
7d5e695652556d2c9b46f3e78316841a831c77b5 6.49 MiB 7.55 MiB 1.07 MiB
cdf717208af3df3b373ff78e404cc7da02e49a29 5.94 MiB 6.95 MiB 1.01 MiB
5aba4171c641227176fb08f4a73fc95f620c4a42 5.94 MiB 6.96 MiB 1.02 MiB
3334ac176f15a6d39b435960620ea9a4919aae79 6.06 MiB 7.03 MiB 993.54 KiB