Send Less Client Reports When Rate Limited

denrase commented 1 month ago

:scroll: Description

[x] Add client reports after rate limit filtering.
[x] Try to send client reports only after getting fully rate limited 10 times.

:bulb: Motivation and Context

Closes #2370

:green_heart: How did you test it?

Unit tests

:pencil: Checklist

[x] I reviewed submitted code
[x] I added tests to verify changes
[ ] No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
[ ] I updated the docs if needed
[x] All tests passing
[x] No breaking changes

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 92.85714% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.72%. Comparing base (4e534f9) to head (d601703). Report is 4 commits behind head on main.

Files with missing lines	Patch %	Lines
...art/lib/src/transport/client_report_transport.dart	90.00%	2 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #2380 +/- ## ======================================= Coverage 84.72% 84.72% ======================================= Files 253 254 +1 Lines 9097 9113 +16 ======================================= + Hits 7707 7721 +14 - Misses 1390 1392 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 1 month ago

Android Performance metrics :rocket:

	Plain	With Sentry	Diff
Startup time	462.71 ms	527.84 ms	65.13 ms
Size	6.49 MiB	7.57 MiB	1.08 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
1a938255a9c0a1073ccebbdb23a70ea2d435013e	347.31 ms	424.54 ms	77.23 ms
a510d1dcfc21014ab20a3aab783acc9f1fa9091c	295.63 ms	344.65 ms	49.03 ms
a7acb24b1deda7eb424909eeb9e0f6897cba2cf0	301.00 ms	357.38 ms	56.38 ms
6034b0a5af03e6891b1153ba6a88f095cbd7a948	406.35 ms	475.93 ms	69.59 ms
2d74010a6f7e9329b48218a0a8931cf732203bd7	400.42 ms	466.50 ms	66.08 ms
4b5a4f6a2eb127d509b6927bbe9ff4220a3b5289	394.19 ms	471.81 ms	77.62 ms
bf8d36c830f147a550bbb452f5d4c1eaa6eb22e8	505.00 ms	563.18 ms	58.18 ms
e82709a24504959ed7fe9b79ba3f038a31b6c5db	361.18 ms	423.50 ms	62.32 ms
c732386ce5f372225fe638c1ded8d02c6e04a8fd	316.84 ms	390.62 ms	73.78 ms
24f71aae695d5763d7ad28592191d95841f59b40	358.49 ms	455.90 ms	97.41 ms

App size

Revision	Plain	With Sentry	Diff
1a938255a9c0a1073ccebbdb23a70ea2d435013e	6.27 MiB	7.20 MiB	956.36 KiB
a510d1dcfc21014ab20a3aab783acc9f1fa9091c	5.94 MiB	6.96 MiB	1.02 MiB
a7acb24b1deda7eb424909eeb9e0f6897cba2cf0	5.94 MiB	6.95 MiB	1.01 MiB
6034b0a5af03e6891b1153ba6a88f095cbd7a948	6.34 MiB	7.29 MiB	970.36 KiB
2d74010a6f7e9329b48218a0a8931cf732203bd7	6.33 MiB	7.26 MiB	943.41 KiB
4b5a4f6a2eb127d509b6927bbe9ff4220a3b5289	6.34 MiB	7.28 MiB	962.57 KiB
bf8d36c830f147a550bbb452f5d4c1eaa6eb22e8	6.49 MiB	7.56 MiB	1.07 MiB
e82709a24504959ed7fe9b79ba3f038a31b6c5db	6.34 MiB	7.29 MiB	970.37 KiB
c732386ce5f372225fe638c1ded8d02c6e04a8fd	6.26 MiB	7.20 MiB	958.78 KiB
24f71aae695d5763d7ad28592191d95841f59b40	6.06 MiB	7.03 MiB	990.30 KiB

Previous results on branch: enha/client-reports-rate-limiting

Startup times

Revision	Plain	With Sentry	Diff
59779114b17e75487f7cbb3c9c119016255aed8a	447.83 ms	485.13 ms	37.30 ms
c7f254c9ea3da8909eef1220daa02c79b53bf5ff	462.83 ms	490.56 ms	27.73 ms
9a345d1e7c9518e83241a06df3c9f1239f07e169	444.06 ms	482.57 ms	38.50 ms
860c2c85678ba30da02d895356717578e6d5f199	445.57 ms	493.96 ms	48.39 ms

App size

Revision	Plain	With Sentry	Diff
59779114b17e75487f7cbb3c9c119016255aed8a	6.49 MiB	7.57 MiB	1.08 MiB
c7f254c9ea3da8909eef1220daa02c79b53bf5ff	6.49 MiB	7.57 MiB	1.08 MiB
9a345d1e7c9518e83241a06df3c9f1239f07e169	6.49 MiB	7.57 MiB	1.08 MiB
860c2c85678ba30da02d895356717578e6d5f199	6.49 MiB	7.57 MiB	1.08 MiB

github-actions[bot] commented 1 month ago

iOS Performance metrics :rocket:

	Plain	With Sentry	Diff
Startup time	1230.21 ms	1251.83 ms	21.62 ms
Size	8.38 MiB	9.75 MiB	1.37 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
d4d08071f7cfa6a1fb4b2a27151bb30a36d607f8	1246.94 ms	1260.69 ms	13.75 ms
f9d18f3411c23172de9bbb769b49dae01834f5e6	1240.20 ms	1242.78 ms	2.57 ms
04bd9e665bd9e8a5f2d1b16c55e4e3fdd18f9b6d	1230.78 ms	1250.71 ms	19.94 ms
051e97a45b67f5c431e8c540585c1786c42670f9	1245.94 ms	1249.51 ms	3.57 ms
b8562d01376a7efe9af802ab0abd9d8226eb4bd7	1249.92 ms	1267.56 ms	17.64 ms
affcf078275df70b443b3150a5ae60951bfa5faa	1240.61 ms	1266.49 ms	25.88 ms
2e8b1e182237a501baa42811cc2cbe335a7bee1b	1247.45 ms	1263.67 ms	16.22 ms
0f067d38500c0ab6b9e85d0b19690ba915d4fea1	1245.71 ms	1269.59 ms	23.88 ms
f1314d57fef996236ceca00725cc9c3acce16d85	1246.46 ms	1270.92 ms	24.46 ms
e239c830ce5177e7392e665600b16745141b4762	1248.40 ms	1269.28 ms	20.89 ms

App size

Revision	Plain	With Sentry	Diff
d4d08071f7cfa6a1fb4b2a27151bb30a36d607f8	8.33 MiB	9.64 MiB	1.31 MiB
f9d18f3411c23172de9bbb769b49dae01834f5e6	8.29 MiB	9.36 MiB	1.07 MiB
04bd9e665bd9e8a5f2d1b16c55e4e3fdd18f9b6d	8.33 MiB	9.61 MiB	1.27 MiB
051e97a45b67f5c431e8c540585c1786c42670f9	8.28 MiB	9.34 MiB	1.06 MiB
b8562d01376a7efe9af802ab0abd9d8226eb4bd7	8.33 MiB	9.54 MiB	1.22 MiB
affcf078275df70b443b3150a5ae60951bfa5faa	8.38 MiB	9.70 MiB	1.33 MiB
2e8b1e182237a501baa42811cc2cbe335a7bee1b	8.33 MiB	9.64 MiB	1.31 MiB
0f067d38500c0ab6b9e85d0b19690ba915d4fea1	8.32 MiB	9.52 MiB	1.20 MiB
f1314d57fef996236ceca00725cc9c3acce16d85	8.10 MiB	9.08 MiB	1004.30 KiB
e239c830ce5177e7392e665600b16745141b4762	8.38 MiB	9.74 MiB	1.36 MiB

Previous results on branch: enha/client-reports-rate-limiting

Startup times

Revision	Plain	With Sentry	Diff
9a345d1e7c9518e83241a06df3c9f1239f07e169	1249.06 ms	1272.39 ms	23.33 ms
860c2c85678ba30da02d895356717578e6d5f199	1260.31 ms	1288.85 ms	28.54 ms
59779114b17e75487f7cbb3c9c119016255aed8a	1234.78 ms	1251.49 ms	16.71 ms
c7f254c9ea3da8909eef1220daa02c79b53bf5ff	1245.04 ms	1274.59 ms	29.55 ms

App size

Revision	Plain	With Sentry	Diff
9a345d1e7c9518e83241a06df3c9f1239f07e169	8.38 MiB	9.75 MiB	1.37 MiB
860c2c85678ba30da02d895356717578e6d5f199	8.38 MiB	9.75 MiB	1.37 MiB
59779114b17e75487f7cbb3c9c119016255aed8a	8.38 MiB	9.75 MiB	1.37 MiB
c7f254c9ea3da8909eef1220daa02c79b53bf5ff	8.38 MiB	9.75 MiB	1.37 MiB

github-actions[bot] commented 3 weeks ago

	Fails
:no_entry_sign:	Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Send Less Client Reports When Rate Limited ([#2380](https://github.com/getsentry/sentry-dart/pull/2380))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by :no_entry_sign: dangerJS against d60170351993784c71df149fa5ad0aee07603ec0

getsentry / sentry-dart