Open dima-kov opened 4 months ago
Hey @dima-kov, thanks for reporting. Yeah this should not be reported. While we're working on a fix, in the meantime you can filter the error out by defining a custom before_send
, see https://docs.sentry.io/platforms/python/configuration/options/#before-send
Ok I see what the problem is now. The DjangoIntegration
is working correctly, ignoring the error as it should. It's the AsyncioIntegration
that intercepts and reports the error. So disabling the integration is another possible temp solution.
For the time being, the custom before_send
is the way to go here. The asyncio integration wraps all tasks indiscriminately and will report any exceptions that happened in a task and were not handled. It doesn't have the context to see that the exception is then ignored higher up.
So even though technically speaking both integrations are working as expected, the out of the box experience is definitely improvement worthy. What we could do is have a predefined denylist of exceptions to ignore in the AsyncioIntegration
.
Would be great to update docs to describe the problem and potential fix example (before send)
Assigning to @getsentry/support for routing ⏲️
How do you use Sentry?
Sentry Saas (sentry.io)
Version
sentry-sdk==2.6.0 django==5.0.6
Steps to Reproduce
python -m uvicorn myproject.asgi:application
RequestAborted
error to sentry UI:As we look into django code: https://github.com/django/django/blob/bcd255cd5ca0a1e686d276cca71f45ec400d84a2/django/core/handlers/asgi.py#L195-L202, raising this exception is expected for every http request, and is handled by django https://github.com/django/django/blob/bcd255cd5ca0a1e686d276cca71f45ec400d84a2/django/core/handlers/asgi.py#L209-L211 so we do not need to send errors on that.
Do you plan to fix this issue?
Expected Result
no error sent to sentry
Actual Result