search

getsentry / sentry-docs

Sentry's documentation (and tools to build it)
https://docs.sentry.io
Other
326 stars 1.43k forks source link

Unclear how Sentry removes IP address #6196

Open smeubank opened 1 year ago

smeubank commented 1 year ago

Core or SDK?

Platform/SDK

Which part? Which one?

https://docs.sentry.io/platforms/javascript/enriching-events/identify-user/#ip_address

Description

i feel like the description is a bit misleading

If the field is omitted, the default value is null. However, due to backwards compatibility concerns, certain platforms (in particular JavaScript) have a different default value for "{{auto}}". SDKs and other clients should not rely on this behavior and should set IP addresses or "{{auto}}" explicitly.

i assumed null != {{auto}} , but it really is?

Suggested Solution

We use the IP that connects to Relay. You can activate server side data scrubbing

include clarification possibly link to server side data scrubbing

getsantry[bot] commented 1 year ago

Routing to @getsentry/team-web-sdk-frontend for triage, due by (vie). ⏲️

bruno-garcia commented 1 year ago

I believe this is a historical thing, it takes IP address by default for events with platform=cocoa and platform=javascript and all other platforms it requires {{auto}}. Could be wrong here, @mitsuhiko knows this though

mitsuhiko commented 1 year ago

I believe this is documented somewhere in the develop docs but the above explanation is what i believe matches relay’s behavior.