Closed JonLiu1993 closed 5 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 83.83%. Comparing base (
235f837
) to head (1fea96e
). Report is 11 commits behind head on master.
Outdated, invalid.
Hi @dg0yt and @JonLiu1993, can you minimally explain why this PR is no longer valid? Or provide a link to a vcpkg
PR/issue that resolves the mentioned problem differently?
@supervacuus, VCPKG has updated sentry-native to 0.7.6 a few days ago. I thought this PR had been merged into it. I checked and found that it was not. I reopened this PR. Sorry for the confusion. https://github.com/microsoft/vcpkg/pull/39255/files
Hi @dg0yt and @JonLiu1993, can you minimally explain why this PR is no longer valid?
It incorrectly reverts find_package
.
It incorrectly reflects the conditions.
Cf. #1011 for all recent comments transformed into a PR.
It incorrectly reverts
find_package
. It incorrectly reflects the conditions.
True, I saw that, but that could have been fixed here.
Cf. https://github.com/getsentry/sentry-native/pull/1011 for all recent comments transformed into a PR.
This includes the proposed feedback from here, so can we close this?
required changes introduced here: #1013
Hi! I have two issues regarding the using of the sentry-native port.
sentry-native
as vcpkg dependency, i'm getting this error:This problem can be solved by adding additional project dependency for zlib in vcpkg. Related issue:https://github.com/getsentry/sentry-native/issues/596 https://github.com/microsoft/vcpkg/issues/39114