Closed supervacuus closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 81.76%. Comparing base (
21c6d0a
) to head (331f8fc
). Report is 1 commits behind head on master.
This works perfectly fine for me. Thank you for the quick action!
Great!
I am just surprised there is an incentive to support such an old OS
I don't particularly appreciate breaking changes (and Sentry agrees). If the effort of implementing and maintaining a fallback is within acceptable bounds and the 99 percentile users are not affected by it, then there is no reason to break.
@supervacuus thanks for this patch, I've just tested 331f8fc91004a716af7a9136314420d8ffc8ea18 on Windows 7 and it worked 👍
This is a fix for the issue raised here: https://github.com/getsentry/sentry-native/pull/1039#issuecomment-2398218262
The problem is that the previous build-time condition only checks if the SDK supports the new API, but the application could later run on a Windows without support.
We look up
GetSystemTimePreciseAsFileTime()
and runtime (duringsentry_init
, at which point it is cached) and fall back toGetSystemTimeAsFileTime()
if we can't find it.@dacap and @ShawnCZek, please look to see if that works for you.