Closed anze3db closed 1 year ago
Hey @anze3db, thanks for the heads up and for pointing us to the commit! We'll need to fix this and whatever other potential compat issues there are with 5.0. (PRs are of course more than welcome!)
The bug seems to be caused by Django singles now having an async option. Take a look here. Django commit
Possibly, this could be fixed by modifying this line (72)
from
for idx, receiver in enumerate(receivers):
to
for idx, receiver in enumerate(receivers[0]):
This would get the sync receivers, which I am guessing is what was used before.
Thanks for the investigation @vincentdavis We will take this into account when we make Sentry SDK ready for Django 5!
How do you use Sentry?
Sentry Saas (sentry.io)
Version
1.31.0
Steps to Reproduce
python manage.py runserver
Expected Result
No exception raised.
Actual Result
The following exception was thrown:
Django added support for async handlers in 5.0 which changed the return value of
Signal._live_receivers
. The relevant commit that broke Sentry's integration: https://github.com/django/django/commit/e83a88566a71a2353cebc35992c110be0f8628af