search

getsentry / sentry-react-native

Official Sentry SDK for React Native
https://sentry.io
MIT License
1.59k stars 337 forks source link

Updates the sample app with an attachment/tags example #4322

Open antonis opened 2 days ago

antonis commented 2 days ago

:loudspeaker: Type of change

⚠️ Based on: https://github.com/getsentry/sentry-react-native/pull/4320

:scroll: Description

Updates the sample app with an attachment/tags example

:bulb: Motivation and Context

Enhance the https://github.com/getsentry/sentry-react-native/pull/4320 sample app with an attachment/tags example

:green_heart: How did you test it?

CI, Manual testing with the sample app.

Screenshot

![Simulator Screenshot - iPhone SE (3rd generation) - 2024-11-27 at 17 58 33](https://github.com/user-attachments/assets/e4cd6b31-0833-4b68-aa44-26de21bf811c)

:pencil: Checklist

:crystal_ball: Next steps

skip-changelog

github-actions[bot] commented 2 days ago

Android (legacy) Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 414.23 ms 406.08 ms -8.15 ms
Size 17.74 MiB 20.09 MiB 2.35 MiB

Baseline results on branch: antonis/3859-newCaptureFeedbackAPI

Startup times

Revision Plain With Sentry Diff
68362f2fe1b598c0cd8f6c6a1fff9b45ab75e9d4 461.20 ms 457.04 ms -4.16 ms
a67330514619ea88198b049351cff84087e9e577 436.21 ms 443.04 ms 6.84 ms
beb77ada8c0d7ff89fbc61b3b6544a1c38b28204 510.00 ms 534.31 ms 24.31 ms
b2f7f821e79458abe881a1b8f2764f8c1cd88970 436.78 ms 435.20 ms -1.58 ms
20be313eee647899a1234e4b45895e0cdb400d08 473.12 ms 490.78 ms 17.66 ms

App size

Revision Plain With Sentry Diff
68362f2fe1b598c0cd8f6c6a1fff9b45ab75e9d4 17.74 MiB 20.09 MiB 2.35 MiB
a67330514619ea88198b049351cff84087e9e577 17.74 MiB 20.09 MiB 2.35 MiB
beb77ada8c0d7ff89fbc61b3b6544a1c38b28204 17.74 MiB 20.09 MiB 2.35 MiB
b2f7f821e79458abe881a1b8f2764f8c1cd88970 17.74 MiB 20.09 MiB 2.35 MiB
20be313eee647899a1234e4b45895e0cdb400d08 17.74 MiB 20.09 MiB 2.35 MiB

Previous results on branch: antonis/3859-newCaptureFeedbackAPI-hint

Startup times

Revision Plain With Sentry Diff
8ac955701640425e7ccdbdc19f87ccf68d180f8a 451.00 ms 458.35 ms 7.35 ms
14e0b04520424bf2385e1696f4fd6b86bdbaaf48 423.13 ms 420.63 ms -2.50 ms

App size

Revision Plain With Sentry Diff
8ac955701640425e7ccdbdc19f87ccf68d180f8a 17.74 MiB 20.09 MiB 2.35 MiB
14e0b04520424bf2385e1696f4fd6b86bdbaaf48 17.74 MiB 20.09 MiB 2.35 MiB
github-actions[bot] commented 2 days ago

Android (new) Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 388.18 ms 445.96 ms 57.78 ms
Size 7.15 MiB 8.37 MiB 1.22 MiB

Baseline results on branch: antonis/3859-newCaptureFeedbackAPI

Startup times

Revision Plain With Sentry Diff
a67330514619ea88198b049351cff84087e9e577+dirty 369.77 ms 414.12 ms 44.36 ms
20be313eee647899a1234e4b45895e0cdb400d08+dirty 401.81 ms 426.80 ms 24.99 ms
b2f7f821e79458abe881a1b8f2764f8c1cd88970+dirty 377.85 ms 440.47 ms 62.61 ms
beb77ada8c0d7ff89fbc61b3b6544a1c38b28204+dirty 393.65 ms 451.71 ms 58.06 ms
68362f2fe1b598c0cd8f6c6a1fff9b45ab75e9d4+dirty 344.64 ms 400.24 ms 55.59 ms

App size

Revision Plain With Sentry Diff
a67330514619ea88198b049351cff84087e9e577+dirty 7.15 MiB 8.37 MiB 1.22 MiB
20be313eee647899a1234e4b45895e0cdb400d08+dirty 7.15 MiB 8.37 MiB 1.22 MiB
b2f7f821e79458abe881a1b8f2764f8c1cd88970+dirty 7.15 MiB 8.37 MiB 1.22 MiB
beb77ada8c0d7ff89fbc61b3b6544a1c38b28204+dirty 7.15 MiB 8.37 MiB 1.22 MiB
68362f2fe1b598c0cd8f6c6a1fff9b45ab75e9d4+dirty 7.15 MiB 8.37 MiB 1.22 MiB

Previous results on branch: antonis/3859-newCaptureFeedbackAPI-hint

Startup times

Revision Plain With Sentry Diff
8ac955701640425e7ccdbdc19f87ccf68d180f8a+dirty 408.89 ms 441.19 ms 32.29 ms
14e0b04520424bf2385e1696f4fd6b86bdbaaf48+dirty 403.86 ms 464.70 ms 60.84 ms

App size

Revision Plain With Sentry Diff
8ac955701640425e7ccdbdc19f87ccf68d180f8a+dirty 7.15 MiB 8.37 MiB 1.22 MiB
14e0b04520424bf2385e1696f4fd6b86bdbaaf48+dirty 7.15 MiB 8.37 MiB 1.22 MiB
github-actions[bot] commented 2 days ago

iOS (legacy) Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 1239.90 ms 1240.02 ms 0.12 ms
Size 2.36 MiB 3.11 MiB 759.85 KiB

Baseline results on branch: antonis/3859-newCaptureFeedbackAPI

Startup times

Revision Plain With Sentry Diff
a67330514619ea88198b049351cff84087e9e577+dirty 1221.76 ms 1224.72 ms 2.97 ms
20be313eee647899a1234e4b45895e0cdb400d08+dirty 1214.98 ms 1228.34 ms 13.36 ms
beb77ada8c0d7ff89fbc61b3b6544a1c38b28204+dirty 1229.25 ms 1228.02 ms -1.23 ms
b2f7f821e79458abe881a1b8f2764f8c1cd88970+dirty 1224.27 ms 1232.24 ms 7.97 ms
68362f2fe1b598c0cd8f6c6a1fff9b45ab75e9d4+dirty 1236.22 ms 1228.98 ms -7.25 ms

App size

Revision Plain With Sentry Diff
a67330514619ea88198b049351cff84087e9e577+dirty 2.36 MiB 3.11 MiB 759.83 KiB
20be313eee647899a1234e4b45895e0cdb400d08+dirty 2.36 MiB 3.11 MiB 759.80 KiB
beb77ada8c0d7ff89fbc61b3b6544a1c38b28204+dirty 2.36 MiB 3.10 MiB 759.77 KiB
b2f7f821e79458abe881a1b8f2764f8c1cd88970+dirty 2.36 MiB 3.10 MiB 759.76 KiB
68362f2fe1b598c0cd8f6c6a1fff9b45ab75e9d4+dirty 2.36 MiB 3.11 MiB 759.82 KiB

Previous results on branch: antonis/3859-newCaptureFeedbackAPI-hint

Startup times

Revision Plain With Sentry Diff
8ac955701640425e7ccdbdc19f87ccf68d180f8a+dirty 1226.52 ms 1231.29 ms 4.76 ms
14e0b04520424bf2385e1696f4fd6b86bdbaaf48+dirty 1224.17 ms 1232.15 ms 7.98 ms

App size

Revision Plain With Sentry Diff
8ac955701640425e7ccdbdc19f87ccf68d180f8a+dirty 2.36 MiB 3.11 MiB 759.80 KiB
14e0b04520424bf2385e1696f4fd6b86bdbaaf48+dirty 2.36 MiB 3.11 MiB 759.92 KiB
github-actions[bot] commented 2 days ago

iOS (new) Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 1237.10 ms 1236.69 ms -0.41 ms
Size 2.92 MiB 3.67 MiB 772.41 KiB

Baseline results on branch: antonis/3859-newCaptureFeedbackAPI

Startup times

Revision Plain With Sentry Diff
a67330514619ea88198b049351cff84087e9e577+dirty 1239.94 ms 1236.31 ms -3.63 ms
20be313eee647899a1234e4b45895e0cdb400d08+dirty 1245.86 ms 1244.17 ms -1.69 ms
beb77ada8c0d7ff89fbc61b3b6544a1c38b28204+dirty 1228.63 ms 1222.55 ms -6.08 ms
b2f7f821e79458abe881a1b8f2764f8c1cd88970+dirty 1242.42 ms 1234.87 ms -7.54 ms
68362f2fe1b598c0cd8f6c6a1fff9b45ab75e9d4+dirty 1232.73 ms 1226.80 ms -5.92 ms

App size

Revision Plain With Sentry Diff
a67330514619ea88198b049351cff84087e9e577+dirty 2.92 MiB 3.67 MiB 772.46 KiB
20be313eee647899a1234e4b45895e0cdb400d08+dirty 2.92 MiB 3.67 MiB 772.42 KiB
beb77ada8c0d7ff89fbc61b3b6544a1c38b28204+dirty 2.92 MiB 3.67 MiB 772.36 KiB
b2f7f821e79458abe881a1b8f2764f8c1cd88970+dirty 2.92 MiB 3.67 MiB 772.44 KiB
68362f2fe1b598c0cd8f6c6a1fff9b45ab75e9d4+dirty 2.92 MiB 3.67 MiB 772.35 KiB

Previous results on branch: antonis/3859-newCaptureFeedbackAPI-hint

Startup times

Revision Plain With Sentry Diff
8ac955701640425e7ccdbdc19f87ccf68d180f8a+dirty 1242.49 ms 1237.18 ms -5.31 ms
14e0b04520424bf2385e1696f4fd6b86bdbaaf48+dirty 1248.87 ms 1236.32 ms -12.56 ms

App size

Revision Plain With Sentry Diff
8ac955701640425e7ccdbdc19f87ccf68d180f8a+dirty 2.92 MiB 3.67 MiB 772.31 KiB
14e0b04520424bf2385e1696f4fd6b86bdbaaf48+dirty 2.92 MiB 3.67 MiB 772.40 KiB
krystofwoldrich commented 1 day ago

Thank you for splitting the PRs, it makes it clear and easy to review!

krystofwoldrich commented 1 day ago

Based on my review of https://github.com/getsentry/sentry-react-native/pull/4320

This PR will boil down to only the sample app update. If I'm not mistaken.

antonis commented 1 day ago

Based on my review of https://github.com/getsentry/sentry-react-native/pull/4320

This PR will boil down to only the sample app update. If I'm not mistaken.

True. Probably there is no need for this now.