getsentry / sentry-unity

Development of Sentry SDK for Unity
https://docs.sentry.io/platforms/unity/
MIT License
218 stars 52 forks source link

Release CI completes without the test suite #1844

Closed bruno-garcia closed 1 month ago

bruno-garcia commented 1 month ago

Release 2.2.1 went out. The release/2.2.1 branch didn't seem to run the tests:

https://github.com/getsentry/sentry-unity/actions/runs/11335211101

Image

bruno-garcia commented 1 month ago

Seems related to:

The release with version version has the full CI run:

The release with release/version doesn't:

Also note the two different bots involved

bitsandfoxes commented 1 month ago

For context: This was done intentionally. The idea was: If main is green it should not take two hours for a release to go through. But as the team is growing we should rethink such a "by convention" processes.

bruno-garcia commented 1 month ago

For context: This was done intentionally. The idea was: If main is green it should not take two hours for a release to go through. But as the team is growing we should rethink such a "by convention" processes.

I see, that makes sense. But do we have safeguards to make sure the build from the branch (not just main) that we're releasing from is green and hence the release build doesn't need CI?

Also, even package validation doesn't run? If we make any mistake during the release flow (bumping versions, etc) no visibility

bitsandfoxes commented 1 month ago

Also, even package validation doesn't run?

Build and Package Validation are part of the Release run.

Image