Cross project error counts are incorrect for replays

[cmanallen]

Environment

SaaS (https://sentry.io/)

Steps to Reproduce

1. Visit the replay index page and observe a replay with at least one error that was raised on different project than the replay was recorded for.
2. Click into the details page of that replay and observe the error count.

Expected Result

The counts should be the same. We should be able to search and sort by cross-project errors.

Actual Result

The count is not the same. We are not able to search and sort by cross-project errors.

Product Area

Replays

Link

No response

DSN

No response

Version

No response

[cmanallen]

This can be fixed by any of the following:

• Making all replay requests cross-project requests (in other words the project selector becomes useless).
  • Pretty big performance implications.
• Using the replay's project-id when event linking.
  • This doesn't impact the error at all. There's no semantic meaning to the project <-> error linkage in this case. We're just trying to associate to a replay-id and a quirk of our composite primary key is preventing that.

[cmanallen]

cc @getsentry/replay-backend

[aliu39]

Related: https://github.com/getsentry/sentry/pull/69973 and https://github.com/getsentry/sentry/pull/70231