getsentry / spotlight

Your Universal Debug Toolbar
https://spotlightjs.com
Other
377 stars 11 forks source link

Enable all features in the SDKs when spotlight:true #247

Open HazAT opened 11 months ago

HazAT commented 11 months ago

When someone sets spotlight:true in a Sentry SDK - we should up all sample rates.

### Tasks
- [ ] Node
- [ ] Python
- [ ] PHP
- [ ] Ruby
dcramer commented 11 months ago

IMO the better approach here would be to move this logic (and define the spec around it) until the envelope crafting bits. This is still not ideal all the time because you're wasting CPU in prod when something might not sample/etc. I dont think we should compromise there, but it also smells funny to magically change the config.

It could just be something like if spotlight or should_sample: do the thing() and put those checks everywhere.

BYK commented 2 weeks ago

Related #543