getsentry / spotlight

Your Universal Debug Toolbar
https://spotlightjs.com
Other
382 stars 11 forks source link

fix: Overhaul envelope parsing to be spec compliant #439

Closed BYK closed 4 months ago

BYK commented 4 months ago

We got some parsing errors recently when using gib-potatoe as our testbed. Turns out our initial parser is a bit naive and cannot work with certain payloads.

This PR rewrites the parser based on the spec at https://develop.sentry.dev/sdk/envelopes/#serialization-format

It also adds new test cases where the old parser fails some of them.

Hoping this parser to be a bit more efficient too.

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
spotlightjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 12, 2024 0:28am