search

getsentry / spotlight

Your Universal Debug Toolbar
https://spotlightjs.com
Other
382 stars 11 forks source link

Switch to @sentry/utils for envelope parsing #460

Closed BYK closed 3 months ago

BYK commented 4 months ago

There's existing envelope parsing code here: https://github.com/getsentry/sentry-javascript/blob/develop/packages/utils/src/envelope.ts

It doesn't make sense maintaining two separate implementations. That said the one over @sentry/utils seem to be failing with some of the edge cases we cover here. We need to upstream these fixes and then switch over to using the common code.

BYK commented 3 months ago

First step: https://github.com/getsentry/sentry-javascript/pull/13191

BYK commented 3 months ago

This is not going to happen as @sentry/utils is meant for JS SDKs and it doesn't care about the edge cases or payloads from other SDKs for the time being.