search

getting-things-gnome / gtg

Getting Things GNOME! trunk
https://wiki.gnome.org/Apps/GTG
GNU General Public License v3.0
559 stars 164 forks source link

Prevent reparenting a tag to itself #1151

Closed gycsaba96 closed 2 weeks ago

gycsaba96 commented 2 weeks ago

Similarly to PR #1149, it was possible to reparent a tag to itself using drag-and-drop. Sidebar.check_parent now checks if the drop target is the same tag we are moving.

Steps to reproduce the bug:

  1. Pick a tag and start dragging it over another tag.
  2. Move it back over itself, and drop it.
  3. Observe the program freezing and eventually running out of memory.

(If it is not against any current plans, I would be happy to experiment with a common StoreItem base class or something similar to prevent such duplicated bugs.)

diegogangl commented 2 weeks ago

Merged, thanks!

(If it is not against any current plans, I would be happy to experiment with a common StoreItem base class or something similar to prevent such duplicated bugs.)

Sure, the only plan right now is to stabilize and release 0.7