getumbrel / umbrel-dashboard

[Deprecated] Moved to https://github.com/getumbrel/umbrel/tree/master/packages/dashboard. Web-based dashboard to interact with your Umbrel.
https://github.com/getumbrel/umbrel/tree/master/packages/dashboard
Other
132 stars 69 forks source link

Add Alby #409

Open secondl1ght opened 2 years ago

secondl1ght commented 2 years ago

Hello 👋🏼

I have added Alby instructions as one of the connect wallet options. Please let me know if you require more details.

Thanks!

secondl1ght commented 2 years ago

@AaronDewes do you need anything else from me on this and does everything look good now?

AaronDewes commented 2 years ago

I'm not an Umbrel Dev, so @louneskmt should probably do a final review.

louneskmt commented 2 years ago

Hi @secondl1ght, thanks for your PR!

Unfortunately, I'm not able to setup Alby with my Umbrel. I've installed the companion app for macOS, then clicked on "Install" for Brave. After entering the lndconnect REST Tor URL, Alby is loading for a few seconds or minutes ("Initializing your account. Please wait, this can take a minute..."), then it fails.

image

Does the companion app need to be kept open or is it possible to close it? I've tried both.

Also, I suppose the user needs to have a running Tor instance on their computer. If that's the case, you'll need to add the appropriate step in the instructions (see this review, the added code is the same).

AaronDewes commented 2 years ago

Alby's companion app automatically starts tor, maybe it crashes if it's already running

louneskmt commented 2 years ago

I've stopped my local Tor instance, reinstalled the Alby extension, still the same error.

louneskmt commented 2 years ago

Maybe it comes from my Brave privacy settings?

AaronDewes commented 2 years ago

Maybe it comes from my Brave privacy settings?

Have you restarted your browser after installing the Alby companion app?

AaronDewes commented 2 years ago

I'm not sure if it even works with Brave, this is their screenshot image

louneskmt commented 2 years ago

Have you restarted your browser after installing the Alby companion app? Yep, two times.

And Brave is definitely supported for me.

image

I also confirm the presence of the config file in Brave.

image
secondl1ght commented 2 years ago

Im going to tag @bumi on this, I know he has Alby running on his Umbrel so I think he should be able to help you debug this and get it working.

bumi commented 2 years ago

Thanks for adding Alby there @secondl1ght And thanks everyone for testing and reporting that error! The Alby app does not need to be running. (The browser manages starting/stopping the app in the background. The macOS app is just needed to configure it once). So it actually looks all good...

Can you check if there is a log file? In the terminal try:tail -n 20 $TMPDIR/alby.log