Clean up bls provider and signer - Githubissues

getwax / bls-wallet

Core components to use layer 2 smart contract wallets with the BLS signature scheme

MIT License

177 stars 45 forks source link

Clean up bls provider and signer #599

Closed JohnGuilding closed 1 year ago

JohnGuilding commented 1 year ago

What is this PR doing?

Updates signMessage method
Resolves some TODOs
Cleans up a few tests
Removes unnecessary integration tests

Viewing the changes by each commit may make it easier to understand which tests were moved rather than deleted

How can these changes be manually tested?

Observing all tests pass

Does this PR resolve or contribute to any issues?

None

Checklist

[x] I have manually tested these changes
[x] Post a link to the PR in the group chat

Guidelines

If your PR is not ready, mark it as a draft
The resolve conversation button is for reviewers, not authors
- (But add a 'done' comment or similar)