ggxl / tortoisesvn

Automatically exported from code.google.com/p/tortoisesvn
0 stars 1 forks source link

Crash editing properties from the repository browser #671

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
When editing properties from the repository browser and an error happens (e.g., 
if the property is invalid or can't be set or ...), the error dialog can show 
up *behind* the properties dialog. If that happens and the user closes the 
properties dialog, TSVN crashes because the error dialog is not cleaned up 
properly.

https://drdump.com/Bug.aspx?ProblemID=85980

Original issue reported on code.google.com by tortoisesvn on 20 Oct 2014 at 5:34

GoogleCodeExporter commented 8 years ago
The problem here is a race condition because of the separate thread the 
progress dialog creates: the progress dialog is pseudo-modal, and when it exits 
it re-enables its parent window, but at that time another dialog (in this case 
the error dialog) is already shown.

Original comment by tortoisesvn on 20 Oct 2014 at 5:36

GoogleCodeExporter commented 8 years ago
This issue was closed by revision r25963.

Original comment by tortoisesvn on 20 Oct 2014 at 7:34

GoogleCodeExporter commented 8 years ago
This issue was closed by revision r25968.

Original comment by tortoisesvn on 21 Oct 2014 at 7:48

GoogleCodeExporter commented 8 years ago

Original comment by tortoisesvn on 21 Oct 2014 at 7:48

GoogleCodeExporter commented 8 years ago
confirmed to appear in older 1.8.8.25755 version.
in my case i got repeated error dialogs for some "/" folder. after a few clicks 
the TSVN part in question crashed. agreed it looked like a race condition or at 
least similar.

confirmed to work for me now in latest TortoiseSVN 1.8.99, Build 26025 - 64 Bit 
-dev, 2014/11/09 17:54:46

Original comment by alexande...@hdle.com on 10 Nov 2014 at 1:57