search

gh2o / digitalocean-debian-to-arch

Script to convert a Debian installation on DigitalOcean to Arch Linux
MIT License
830 stars 69 forks source link

Zero out GRUB_TIMEOUT #51

Closed injust closed 6 years ago

injust commented 7 years ago

The default 5-second GRUB_TIMEOUT has no practical benefit, and only serves to slow down the reboot, as well as any future reboots as well.

Given that there may be potential use cases for the default timeout (in case you want to poke around in GRUB), maybe this should be added in as a parameter instead?

gh2o commented 7 years ago

Hey @Injust, thank you for your PR. I can't justify setting it as the default, as some users (myself included) find it useful to use the fallback initramfs if something goes wrong. Making it a parameter would be useful.

injust commented 7 years ago

@gh2o I've reintegrated the PR as a parameter. Could you please take another look at it?

injust commented 7 years ago

Sorry, spaces got stripped without me realizing. I've re-added them. Thanks for the heads up!