Closed ghiscoding closed 4 months ago
Run & review this pull request in StackBlitz Codeflow.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 99.8%. Comparing base (
828eb8a
) to head (f7ce7a6
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
filterPredicate
regressed with a new issue and that was not caught in the original PR. It had the indirect effect of breaking the other filter columns (I forgot to test that in the original PR), the issue was caused by the fact that calling areturn
within thefor
loop of all filters was cancelling all other filters in the loop because areturn
breaks the entire loop.return
when thefilterPredicate
returnsfalse
which mean that at point the row data context is officially filtered out and so stopping inspection of further filters does make sense at that point in time.Ta%30%
, it wasn't working correctly before and it is now equivalent to: StartsWith "Ta" and Contains "30" anywherebelow with the fix, other column filters now work (before the fix, the 2nd column filter wasn't doing anything)