ghiscoding / slickgrid-universal

Slickgrid-Universal is a monorepo which includes all Editors, Filters, Extensions, Services related to SlickGrid usage and is also Framework Agnostic
https://ghiscoding.github.io/slickgrid-universal/
MIT License
83 stars 26 forks source link

fix(filters): new `filterPredicate` shouldn't break other column filters #1531

Closed ghiscoding closed 4 months ago

ghiscoding commented 4 months ago

below with the fix, other column filters now work (before the fix, the 2nd column filter wasn't doing anything)

msedge_bbEm4vYgpN

stackblitz[bot] commented 4 months ago

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.8%. Comparing base (828eb8a) to head (f7ce7a6).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1531 +/- ## ======================================== + Coverage 99.8% 99.8% +0.1% ======================================== Files 198 198 Lines 21621 21623 +2 Branches 6951 7222 +271 ======================================== + Hits 21560 21562 +2 + Misses 61 55 -6 - Partials 0 6 +6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.