ghost-fvtt / fxmaster

A module for Foundry Virtual Tabletop that adds various special effects.
Other
18 stars 13 forks source link

[v12] FX Effect with tint stops effect #767

Closed STBaf closed 2 months ago

STBaf commented 2 months ago

Expected Behavior

In the past you were able to "Tint" effects (like: Bloodrain = Rain Effect with Red Tint for example).

Current Behavior

When you Tint a Effect something seem to go wrong and the effect completely stops. If you remove the checkbox for tint and save effect reappears (with base color for sure)

Steps to Reproduce

  1. Set a effect in a scene with FXMaster, like "Rain Top Down" or "Rain"
  2. Activate the effect, you will see effect happen
  3. Enable Tint Checkbox for Effect, choose any color
  4. Save Changes, Effect stops
  5. Remove Tint Checkbox
  6. Save Changes, Effect is back

Context

This has worked in v11, in v12 stopped working

Version

4.1.0

Foundry VTT Version

12.331

Operating System

Windows client / Server is Nodejs Linux

Browser / App

Microsoft Edge

Game System

dnd5e (3.3.1)

Relevant Modules

No response

STBaf commented 2 months ago

Sorry - cancel that since I wasn't able to reproduce on a fresh scene. This seem only to happen when you got a scene which existed before in v11 and you only change/delete single effects. Once you choose the trash button all effects are deleted (seemingly completely) and after that you can reattach effects which can be tinted (I assume pushing the trash button for all effects clears the complete FXMaster node from the scene configuration out of the dataobject while only uncheck effects will produce remaining old, broken FXMaster configuration data. So workaround: just delete all and reattach fresh. That's good enough for a old v11 imported scene, I think