search

ghostery / user-agent-android

Ghostery Android Browser
https://play.google.com/store/apps/details?id=com.ghostery.android.ghostery
Mozilla Public License 2.0
35 stars 6 forks source link

Ghostery addon Enhanced settings cannot activate #3

Closed chrmod closed 4 years ago

chrmod commented 4 years ago

Flipping the switch for enhanced tracking protection, adblocking or smart ad-blocking has no effect.

christophertino commented 4 years ago

@IAmThePan Can you take a look?

IAmThePan commented 4 years ago

Hey guys, I'm looking at this now using the Ghsotery Browser on Android version 3.0.0-rc2 (Build #21921427).

I find that I can toggle those features. Flow:

  1. Navigate to truthout.org
  2. Click the Ghosty Icon in the top left corner
  3. Click Anti-Tracking and Ad-Blocking icons.
  4. Click back icon in top left corner
  5. Refresh page, open Ghostery, see that Anti-Tracking and Ad-Blocking are highlighted. See that there are 2 Requests Modified. (screenshots attached) Screenshot_20200714_144327_com ghostery android ghostery Screenshot_20200714_144348_com ghostery android ghostery

I am also able to see that these features are toggled correctly by navigating to moz-extension://extension-uuid-big-number/app/templates/panel.html. From here I can see the status of Anti-Tracking, Ad-Blocking & Smart Blocking. I can open Ghostery via the Ghosty in the top left corner, toggle these features and see they have been toggled when I return to the Panel.html page and refresh.

I have experienced some bugs where the UI crashes when I toggle Anti Tracking or Ad Blocking and those features remain un-toggled when I re-open the UI.

christophertino commented 4 years ago

@chrmod This looks to be working in the latest build. Can you confirm?

chrmod commented 4 years ago

@christophertino @IAmThePan I can confirm that settings work well now.

I only have one comment: the font size (& entire UI) seems to be pretty small right now. I can imagine this can be an issue for some users.

Screenshot 2020-07-22 at 14 22 18

Can you please link to the Ghostery Extension PR that introduce those changes? I would like to see what was the problem.

christophertino commented 4 years ago

@chrmod I think this is part of a rendering bug that we're trying to figure out, because my Galaxy J3 (Android 9) does not look like that. Also, notice how in your screenshot you are missing the tab titles in the blue bar? They show correctly on my device.

I asked a few people that were experiencing this bug to side-load the same Ghostery extension code into FF Android Beta. Everything rendered properly, which leads me to believe there's something strange happening in our fostery integration.

We are currently working from the feature/update-android branch on Caleb's fork if you want to help us debug.